You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/21 08:23:11 UTC
[GitHub] [flink] pyscala opened a new pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
pyscala opened a new pull request #13214:
URL: https://github.com/apache/flink/pull/13214
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
1.Throw better exception message for quering sink-only(source-only) connector.
2.Add tips(support as source or sink) following the identifier when 1 heppens.
## Brief change log
- Throw better exception message for quering sink-only(source-only) connector.
For example, when we are quering a sink-only connector ,if we have a dependency jar in the classpath ,return the following excception message:
before:
`Caused by: org.apache.flink.table.api.ValidationException: Could not find any factory for identifier 'elasticsearch-7' that implements 'org.apache.flink.table.factories.DynamicTableSourceFactory' in the classpath.`
now:
`Caused by: org.apache.flink.table.api.ValidationException: The connector named 'elasticsearch-7' is only supported as sink,can n't be used as a source.`
- Add tips follow the identifier when 1 heppens.
before:
`Available factory identifiers are:`
`datagen`
now:
`Available factory identifiers are: `
`datagen (source,sink)`
`elasticsearch-7 (sink-only)`
`test-connector (source-only)`
## Verifying this change
This change added tests and can be verified by running unit test named 'testAvailableFactoryTipsNoDependencyJar()' and 'testAvailableFactoryTipsDependencyJar()' in class `FactoryUtilTest` .
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? ( no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
}, {
"hash" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415",
"triggerID" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"triggerType" : "PUSH"
}, {
"hash" : "f52a874614a324f9aa5f830ddd1978700408d473",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6477",
"triggerID" : "f52a874614a324f9aa5f830ddd1978700408d473",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* f52a874614a324f9aa5f830ddd1978700408d473 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6477)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pyscala commented on a change in pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
pyscala commented on a change in pull request #13214:
URL: https://github.com/apache/flink/pull/13214#discussion_r491815885
##########
File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/factories/TestFormatDeserializationOnlyFactory.java
##########
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.factories;
+
+import org.apache.flink.api.common.serialization.DeserializationSchema;
+import org.apache.flink.configuration.ConfigOption;
+import org.apache.flink.configuration.ReadableConfig;
+import org.apache.flink.table.connector.format.DecodingFormat;
+import org.apache.flink.table.data.RowData;
+
+import java.util.Collections;
+import java.util.Set;
+
+/**
+ * Tests implementations for {@link DeserializationFormatFactory}.
+ */
+public class TestFormatDeserializationOnlyFactory implements DeserializationFormatFactory {
+
+ public static final String IDENTIFIER = "test-format-deserialization-only";
+
+ /**
+ * Creates a format from the given context and format options.
+ *
+ * <p>The format options have been projected to top-level options (e.g. from {@code key.format.ignore-errors}
+ * to {@code format.ignore-errors}).
+ *
+ * @param context
+ * @param formatOptions
+ */
Review comment:
@wuchong Thanks for your reply. Sounds good to me, I will do it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pyscala edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
pyscala edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-716513317
@wuchong Sorry for later reply.
Wrap the pretty exception message in `getDynamicTableFactory` and Keep `FactoryUtil#discoverOptionalFactory` is a generic method for all kinds of factories.
However, because the abnormal judgment logic is more complicated, methed named `isMatchingFactoryEmpty` and `getAvailableFactoryTips` have been added to assist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
}, {
"hash" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415",
"triggerID" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* 734bb7cb193a2d5067a957ce2def7a926fe09589 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375)
* aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
}, {
"hash" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415",
"triggerID" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"triggerType" : "PUSH"
}, {
"hash" : "f52a874614a324f9aa5f830ddd1978700408d473",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6477",
"triggerID" : "f52a874614a324f9aa5f830ddd1978700408d473",
"triggerType" : "PUSH"
}, {
"hash" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6482",
"triggerID" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"triggerType" : "PUSH"
}, {
"hash" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7075",
"triggerID" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"triggerType" : "PUSH"
}, {
"hash" : "86fd7ea0db4fc5c6e62f2aa259592b510677c874",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8299",
"triggerID" : "86fd7ea0db4fc5c6e62f2aa259592b510677c874",
"triggerType" : "PUSH"
}, {
"hash" : "985c2d40aec3e20a402998b16d7eaf8d73ad9738",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8350",
"triggerID" : "985c2d40aec3e20a402998b16d7eaf8d73ad9738",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* 985c2d40aec3e20a402998b16d7eaf8d73ad9738 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8350)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-723966883
Hi @pyscala , thanks for the updating and sorry for the late reviewing. I helped to improve the code and will merge it once build is passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
}, {
"hash" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415",
"triggerID" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"triggerType" : "PUSH"
}, {
"hash" : "f52a874614a324f9aa5f830ddd1978700408d473",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6477",
"triggerID" : "f52a874614a324f9aa5f830ddd1978700408d473",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415)
* f52a874614a324f9aa5f830ddd1978700408d473 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6477)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #13214:
URL: https://github.com/apache/flink/pull/13214#discussion_r490207066
##########
File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/factories/TestFormatDeserializationOnlyFactory.java
##########
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.factories;
+
+import org.apache.flink.api.common.serialization.DeserializationSchema;
+import org.apache.flink.configuration.ConfigOption;
+import org.apache.flink.configuration.ReadableConfig;
+import org.apache.flink.table.connector.format.DecodingFormat;
+import org.apache.flink.table.data.RowData;
+
+import java.util.Collections;
+import java.util.Set;
+
+/**
+ * Tests implementations for {@link DeserializationFormatFactory}.
+ */
+public class TestFormatDeserializationOnlyFactory implements DeserializationFormatFactory {
+
+ public static final String IDENTIFIER = "test-format-deserialization-only";
+
+ /**
+ * Creates a format from the given context and format options.
+ *
+ * <p>The format options have been projected to top-level options (e.g. from {@code key.format.ignore-errors}
+ * to {@code format.ignore-errors}).
+ *
+ * @param context
+ * @param formatOptions
+ */
Review comment:
Remove all the unnecessary comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
}, {
"hash" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415",
"triggerID" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"triggerType" : "PUSH"
}, {
"hash" : "f52a874614a324f9aa5f830ddd1978700408d473",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6477",
"triggerID" : "f52a874614a324f9aa5f830ddd1978700408d473",
"triggerType" : "PUSH"
}, {
"hash" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6482",
"triggerID" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"triggerType" : "PUSH"
}, {
"hash" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7075",
"triggerID" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"triggerType" : "PUSH"
}, {
"hash" : "86fd7ea0db4fc5c6e62f2aa259592b510677c874",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "86fd7ea0db4fc5c6e62f2aa259592b510677c874",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* 3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7075)
* 86fd7ea0db4fc5c6e62f2aa259592b510677c874 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* f3fddf535055b9c780f71ac0a9c84d94f5022858 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782)
* 734bb7cb193a2d5067a957ce2def7a926fe09589 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9299db773f71a9ae48085434a2604c566cb20832 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767)
* ef62ec54b70560a9dabc09f020f7386d907aab20 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
}, {
"hash" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415",
"triggerID" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"triggerType" : "PUSH"
}, {
"hash" : "f52a874614a324f9aa5f830ddd1978700408d473",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6477",
"triggerID" : "f52a874614a324f9aa5f830ddd1978700408d473",
"triggerType" : "PUSH"
}, {
"hash" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6482",
"triggerID" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"triggerType" : "PUSH"
}, {
"hash" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7075",
"triggerID" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"triggerType" : "PUSH"
}, {
"hash" : "86fd7ea0db4fc5c6e62f2aa259592b510677c874",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8299",
"triggerID" : "86fd7ea0db4fc5c6e62f2aa259592b510677c874",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* 3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7075)
* 86fd7ea0db4fc5c6e62f2aa259592b510677c874 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8299)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
}, {
"hash" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415",
"triggerID" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"triggerType" : "PUSH"
}, {
"hash" : "f52a874614a324f9aa5f830ddd1978700408d473",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6477",
"triggerID" : "f52a874614a324f9aa5f830ddd1978700408d473",
"triggerType" : "PUSH"
}, {
"hash" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6482",
"triggerID" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"triggerType" : "PUSH"
}, {
"hash" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7075",
"triggerID" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"triggerType" : "PUSH"
}, {
"hash" : "86fd7ea0db4fc5c6e62f2aa259592b510677c874",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8299",
"triggerID" : "86fd7ea0db4fc5c6e62f2aa259592b510677c874",
"triggerType" : "PUSH"
}, {
"hash" : "985c2d40aec3e20a402998b16d7eaf8d73ad9738",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8350",
"triggerID" : "985c2d40aec3e20a402998b16d7eaf8d73ad9738",
"triggerType" : "PUSH"
}, {
"hash" : "e49c5246de95b3ecb6c7490440b06b6f6e602e8e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e49c5246de95b3ecb6c7490440b06b6f6e602e8e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* 985c2d40aec3e20a402998b16d7eaf8d73ad9738 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8350)
* e49c5246de95b3ecb6c7490440b06b6f6e602e8e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
}, {
"hash" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415",
"triggerID" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"triggerType" : "PUSH"
}, {
"hash" : "f52a874614a324f9aa5f830ddd1978700408d473",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6477",
"triggerID" : "f52a874614a324f9aa5f830ddd1978700408d473",
"triggerType" : "PUSH"
}, {
"hash" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* f52a874614a324f9aa5f830ddd1978700408d473 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6477)
* 9058d2cfe2eaa7811c85232d50e610b5af38570b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef62ec54b70560a9dabc09f020f7386d907aab20 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
}, {
"hash" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415",
"triggerID" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"triggerType" : "PUSH"
}, {
"hash" : "f52a874614a324f9aa5f830ddd1978700408d473",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6477",
"triggerID" : "f52a874614a324f9aa5f830ddd1978700408d473",
"triggerType" : "PUSH"
}, {
"hash" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6482",
"triggerID" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* f52a874614a324f9aa5f830ddd1978700408d473 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6477)
* 9058d2cfe2eaa7811c85232d50e610b5af38570b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6482)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
}, {
"hash" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415",
"triggerID" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"triggerType" : "PUSH"
}, {
"hash" : "f52a874614a324f9aa5f830ddd1978700408d473",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6477",
"triggerID" : "f52a874614a324f9aa5f830ddd1978700408d473",
"triggerType" : "PUSH"
}, {
"hash" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6482",
"triggerID" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"triggerType" : "PUSH"
}, {
"hash" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7075",
"triggerID" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* 9058d2cfe2eaa7811c85232d50e610b5af38570b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6482)
* 3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7075)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* 734bb7cb193a2d5067a957ce2def7a926fe09589 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef62ec54b70560a9dabc09f020f7386d907aab20 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771)
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* f3fddf535055b9c780f71ac0a9c84d94f5022858 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pyscala commented on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
pyscala commented on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-701128918
@wuchong The following changes have been made.
1.Keep FactoryUtil#discoverFactory is still a generic method for all kinds of factories.
2.Adding a new method <T extends Factory> OptionalFailure<T> discoverOptionalFactory
and using this method to check whether the connector/format is avaible and throw better exception in getDynamicTableFactory and discoverOptionalFormatFactory.
Looking forward to your reply.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* f3fddf535055b9c780f71ac0a9c84d94f5022858 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pyscala commented on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
pyscala commented on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-690086075
Hi @wuchong , The changes we discussed have been completed. Looking forward to your reply.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pyscala commented on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
pyscala commented on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-716513317
@wuchong Sorry for later reply.
Wrap the pretty exception message in getDynamicTableFactory and Keep `FactoryUtil#discoverOptionalFactory` is a generic method for all kinds of factories.
However, because the abnormal judgment logic is more complicated, methed named `isMatchingFactoryEmpty` and `getAvailableFactoryTips` have been added to assist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9299db773f71a9ae48085434a2604c566cb20832 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
}, {
"hash" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415",
"triggerID" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"triggerType" : "PUSH"
}, {
"hash" : "f52a874614a324f9aa5f830ddd1978700408d473",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6477",
"triggerID" : "f52a874614a324f9aa5f830ddd1978700408d473",
"triggerType" : "PUSH"
}, {
"hash" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6482",
"triggerID" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"triggerType" : "PUSH"
}, {
"hash" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7075",
"triggerID" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"triggerType" : "PUSH"
}, {
"hash" : "86fd7ea0db4fc5c6e62f2aa259592b510677c874",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8299",
"triggerID" : "86fd7ea0db4fc5c6e62f2aa259592b510677c874",
"triggerType" : "PUSH"
}, {
"hash" : "985c2d40aec3e20a402998b16d7eaf8d73ad9738",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "985c2d40aec3e20a402998b16d7eaf8d73ad9738",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* 86fd7ea0db4fc5c6e62f2aa259592b510677c874 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8299)
* 985c2d40aec3e20a402998b16d7eaf8d73ad9738 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-705956351
Hi @pyscala , thanks for the updating.
However, the new added `discoverOptionalFactory` method still no generic method for all kinds of fatories. What I mean was that you can just call `discoverFactory` and catch the exception in `discoverOptionalFactory`. And wrap the pretty exception message in `getDynamicTableFactory`. In `getDynamicTableFactory` you can use `discoverOptionalFactory` to discover for source and sink both and throw better exception if it is source-only but discovering sink or vise-versa.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pyscala commented on a change in pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
pyscala commented on a change in pull request #13214:
URL: https://github.com/apache/flink/pull/13214#discussion_r491815885
##########
File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/factories/TestFormatDeserializationOnlyFactory.java
##########
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.factories;
+
+import org.apache.flink.api.common.serialization.DeserializationSchema;
+import org.apache.flink.configuration.ConfigOption;
+import org.apache.flink.configuration.ReadableConfig;
+import org.apache.flink.table.connector.format.DecodingFormat;
+import org.apache.flink.table.data.RowData;
+
+import java.util.Collections;
+import java.util.Set;
+
+/**
+ * Tests implementations for {@link DeserializationFormatFactory}.
+ */
+public class TestFormatDeserializationOnlyFactory implements DeserializationFormatFactory {
+
+ public static final String IDENTIFIER = "test-format-deserialization-only";
+
+ /**
+ * Creates a format from the given context and format options.
+ *
+ * <p>The format options have been projected to top-level options (e.g. from {@code key.format.ignore-errors}
+ * to {@code format.ignore-errors}).
+ *
+ * @param context
+ * @param formatOptions
+ */
Review comment:
@wuchong Thanks for your reply. Sounds good to me, I will do it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
}, {
"hash" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415",
"triggerID" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"triggerType" : "PUSH"
}, {
"hash" : "f52a874614a324f9aa5f830ddd1978700408d473",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6477",
"triggerID" : "f52a874614a324f9aa5f830ddd1978700408d473",
"triggerType" : "PUSH"
}, {
"hash" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6482",
"triggerID" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"triggerType" : "PUSH"
}, {
"hash" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7075",
"triggerID" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"triggerType" : "PUSH"
}, {
"hash" : "86fd7ea0db4fc5c6e62f2aa259592b510677c874",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8299",
"triggerID" : "86fd7ea0db4fc5c6e62f2aa259592b510677c874",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* 86fd7ea0db4fc5c6e62f2aa259592b510677c874 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8299)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
}, {
"hash" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415",
"triggerID" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"triggerType" : "PUSH"
}, {
"hash" : "f52a874614a324f9aa5f830ddd1978700408d473",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6477",
"triggerID" : "f52a874614a324f9aa5f830ddd1978700408d473",
"triggerType" : "PUSH"
}, {
"hash" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6482",
"triggerID" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"triggerType" : "PUSH"
}, {
"hash" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* 9058d2cfe2eaa7811c85232d50e610b5af38570b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6482)
* 3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-705956351
Hi @pyscala , thanks for the updating.
However, the new added `discoverOptionalFactory` method still no generic method for all kinds of fatories. What I mean was that you can just call `discoverFactory` and catch the exception in `discoverOptionalFactory`. And wrap the pretty exception message in `getDynamicTableFactory`. In `getDynamicTableFactory` you can use `discoverOptionalFactory` to discover for source and sink both and throw better exception if it is source-only but discovering sink or vise-versa.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
}, {
"hash" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415",
"triggerID" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"triggerType" : "PUSH"
}, {
"hash" : "f52a874614a324f9aa5f830ddd1978700408d473",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6477",
"triggerID" : "f52a874614a324f9aa5f830ddd1978700408d473",
"triggerType" : "PUSH"
}, {
"hash" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6482",
"triggerID" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"triggerType" : "PUSH"
}, {
"hash" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7075",
"triggerID" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"triggerType" : "PUSH"
}, {
"hash" : "86fd7ea0db4fc5c6e62f2aa259592b510677c874",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8299",
"triggerID" : "86fd7ea0db4fc5c6e62f2aa259592b510677c874",
"triggerType" : "PUSH"
}, {
"hash" : "985c2d40aec3e20a402998b16d7eaf8d73ad9738",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8350",
"triggerID" : "985c2d40aec3e20a402998b16d7eaf8d73ad9738",
"triggerType" : "PUSH"
}, {
"hash" : "e49c5246de95b3ecb6c7490440b06b6f6e602e8e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9349",
"triggerID" : "e49c5246de95b3ecb6c7490440b06b6f6e602e8e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* e49c5246de95b3ecb6c7490440b06b6f6e602e8e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9349)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
}, {
"hash" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* 734bb7cb193a2d5067a957ce2def7a926fe09589 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375)
* aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
}, {
"hash" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415",
"triggerID" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"triggerType" : "PUSH"
}, {
"hash" : "f52a874614a324f9aa5f830ddd1978700408d473",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6477",
"triggerID" : "f52a874614a324f9aa5f830ddd1978700408d473",
"triggerType" : "PUSH"
}, {
"hash" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6482",
"triggerID" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* 9058d2cfe2eaa7811c85232d50e610b5af38570b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6482)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9299db773f71a9ae48085434a2604c566cb20832 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767)
* ef62ec54b70560a9dabc09f020f7386d907aab20 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #13214:
URL: https://github.com/apache/flink/pull/13214
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef62ec54b70560a9dabc09f020f7386d907aab20 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771)
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* f3fddf535055b9c780f71ac0a9c84d94f5022858 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
}, {
"hash" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415",
"triggerID" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"triggerType" : "PUSH"
}, {
"hash" : "f52a874614a324f9aa5f830ddd1978700408d473",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6477",
"triggerID" : "f52a874614a324f9aa5f830ddd1978700408d473",
"triggerType" : "PUSH"
}, {
"hash" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6482",
"triggerID" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"triggerType" : "PUSH"
}, {
"hash" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7075",
"triggerID" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* 3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7075)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
}, {
"hash" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415",
"triggerID" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"triggerType" : "PUSH"
}, {
"hash" : "f52a874614a324f9aa5f830ddd1978700408d473",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6477",
"triggerID" : "f52a874614a324f9aa5f830ddd1978700408d473",
"triggerType" : "PUSH"
}, {
"hash" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6482",
"triggerID" : "9058d2cfe2eaa7811c85232d50e610b5af38570b",
"triggerType" : "PUSH"
}, {
"hash" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7075",
"triggerID" : "3ecb8f70a2565a6100d8f1c564fa17fdc96bb0fe",
"triggerType" : "PUSH"
}, {
"hash" : "86fd7ea0db4fc5c6e62f2aa259592b510677c874",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8299",
"triggerID" : "86fd7ea0db4fc5c6e62f2aa259592b510677c874",
"triggerType" : "PUSH"
}, {
"hash" : "985c2d40aec3e20a402998b16d7eaf8d73ad9738",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8350",
"triggerID" : "985c2d40aec3e20a402998b16d7eaf8d73ad9738",
"triggerType" : "PUSH"
}, {
"hash" : "e49c5246de95b3ecb6c7490440b06b6f6e602e8e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9349",
"triggerID" : "e49c5246de95b3ecb6c7490440b06b6f6e602e8e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* 985c2d40aec3e20a402998b16d7eaf8d73ad9738 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8350)
* e49c5246de95b3ecb6c7490440b06b6f6e602e8e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9349)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pyscala commented on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
pyscala commented on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678625977
@wuchong Appreciate for your time to review this PR.thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678113892
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 9299db773f71a9ae48085434a2604c566cb20832 (Fri Aug 21 08:25:44 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18938).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9299db773f71a9ae48085434a2604c566cb20832 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
}, {
"hash" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415",
"triggerID" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
}, {
"hash" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5782",
"triggerID" : "f3fddf535055b9c780f71ac0a9c84d94f5022858",
"triggerType" : "PUSH"
}, {
"hash" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6375",
"triggerID" : "734bb7cb193a2d5067a957ce2def7a926fe09589",
"triggerType" : "PUSH"
}, {
"hash" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415",
"triggerID" : "aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0",
"triggerType" : "PUSH"
}, {
"hash" : "f52a874614a324f9aa5f830ddd1978700408d473",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52a874614a324f9aa5f830ddd1978700408d473",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
* aa78f74d8efbf509e2d9247d43cd68ff8e9db0b0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6415)
* f52a874614a324f9aa5f830ddd1978700408d473 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13214: [FLINK-18938][tableSQL/API] Throw better exception message for quering sink-only connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13214:
URL: https://github.com/apache/flink/pull/13214#issuecomment-678119788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9299db773f71a9ae48085434a2604c566cb20832",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5767",
"triggerID" : "9299db773f71a9ae48085434a2604c566cb20832",
"triggerType" : "PUSH"
}, {
"hash" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771",
"triggerID" : "ef62ec54b70560a9dabc09f020f7386d907aab20",
"triggerType" : "PUSH"
}, {
"hash" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8fcc0f241851849e0b3faefa88aea5d6649662",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef62ec54b70560a9dabc09f020f7386d907aab20 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5771)
* 8c8fcc0f241851849e0b3faefa88aea5d6649662 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org