You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/11/28 12:33:04 UTC

[GitHub] [incubator-eventmesh] Bigotry-zb commented on a diff in pull request #2290: [ISSUE #2243] Change Boolean to boolean in NacosWebHookConfigOperation

Bigotry-zb commented on code in PR #2290:
URL: https://github.com/apache/incubator-eventmesh/pull/2290#discussion_r1033486289


##########
eventmesh-webhook/eventmesh-webhook-admin/src/main/java/org/apache/eventmesh/webhook/admin/NacosWebHookConfigOperation.java:
##########
@@ -105,7 +105,8 @@ public Integer insertWebHookConfig(WebHookConfig webHookConfig) {
 
     @Override
     public Integer updateWebHookConfig(WebHookConfig webHookConfig) {
-        Boolean result = false;
+        // 修改代码部分

Review Comment:
   > Please don't use Chinese.
   
   Thanks for your suggestion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org