You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/08 07:31:47 UTC

[GitHub] [airflow] mik-laj commented on pull request #9171: Check GCP guides on docs build stage on CI

mik-laj commented on pull request #9171:
URL: https://github.com/apache/airflow/pull/9171#issuecomment-640421820


   We can extend it, but in this change, I would only like to check this data in a more appropriate place. 
   
   When this check was added, other providers did not have guides, so I did not want to introduce new rules. In the case of GCP, it is a generally accepted rule that we have guides and we keep them. I am trying to convince contributors to write guides using other ways, because I am afraid that if the contributors see that there are no guides for other services, but I expect that he will write a guide for his service, he will feel bad about it. When we have over 50% coverage for a given provider, we should enforce these rules more widely.
   
   This check will also be difficult to add for some providers if they have operator sets for one service placed in multiple files.
   airflow.providers.apache.spark.hooks.spark_jdbc, airflow.providers.apache.spark.hooks.spark_jdbc_script, airflow.providers.apache.spark.hooks.spark_sql, airflow.providers.apache.spark.hooks.spark_submit
   airflow.providers.microsoft.azure.hooks.azure_container_instance, airflow.providers.microsoft.azure.hooks.azure_container_registry, airflow.providers.microsoft.azure.hooks.azure_container_volume
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org