You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by ravikiran23 <gi...@git.apache.org> on 2016/09/14 15:51:43 UTC
[GitHub] incubator-carbondata pull request #155: [CARBONDATA-239] Handling the except...
GitHub user ravikiran23 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/155
[CARBONDATA-239] Handling the exception cases in compaction.
Why raise this pr?
If a compaction is triggered by the user on table1 , and other requests will go to queue. and if the compaction is failed for table1 then the requests in queue is not getting completed.
How to resolve?
If the compaction is failed then the requests in queue should continue the compaction.
if compaction is failed for table, requested by user then need to show error message in the beeline.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravikiran23/incubator-carbondata ExceptionHandlingInCompaction
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/155.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #155
----
commit 03964c4c0b900d3e6e7fc5c62e507328836269a8
Author: ravikiran <ra...@gmail.com>
Date: 2016-09-14T12:39:54Z
handling the exception cases in compaction.
if compaction is failed for table requested by user then need to show error message in the beeline.
and if any exception occurs then need to continue compaction for the queued compactions.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #155: [CARBONDATA-239] Handling the except...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/155#discussion_r79208835
--- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ---
@@ -590,16 +605,25 @@ object CarbonDataRDDFactory extends Logging {
executor, sqlContext, kettleHomePath, storeLocation
)
}
+ catch {
+ case e: Exception =>
+ logger.error("Exception in compaction thread for table " + tableForCompaction
+ .carbonTable.getDatabaseName + "." +
+ tableForCompaction.carbonTableIdentifier
+ .getTableName)
+ // not handling the exception. only logging as this is not the table triggered
+ // by user.
+ }
finally {
- // delete the compaction required file
+ // delete the compaction required file in case of failure or success also.
--- End diff --
If compact file deletion fails, add failed table to skipped list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #155: [CARBONDATA-239] Handling the except...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/155
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #155: [CARBONDATA-239] Handling the except...
Posted by ravikiran23 <gi...@git.apache.org>.
Github user ravikiran23 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/155#discussion_r79283801
--- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ---
@@ -590,16 +605,25 @@ object CarbonDataRDDFactory extends Logging {
executor, sqlContext, kettleHomePath, storeLocation
)
}
+ catch {
+ case e: Exception =>
+ logger.error("Exception in compaction thread for table " + tableForCompaction
+ .carbonTable.getDatabaseName + "." +
+ tableForCompaction.carbonTableIdentifier
+ .getTableName)
+ // not handling the exception. only logging as this is not the table triggered
+ // by user.
+ }
finally {
- // delete the compaction required file
+ // delete the compaction required file in case of failure or success also.
--- End diff --
fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---