You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (Created) (JIRA)" <ji...@apache.org> on 2012/02/08 12:02:57 UTC
[jira] [Created] (WICKET-4396) Impossible to group header
contributions in the
Impossible to group header contributions in the <head>
------------------------------------------------------
Key: WICKET-4396
URL: https://issues.apache.org/jira/browse/WICKET-4396
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.0.0
Reporter: Martin Grigorov
Assignee: Emond Papegaaij
There is a regression in Wicket 6.0 that doesn't allow to have a HeaderResponseContainer in the <head> section.
It fails because its org.apache.wicket.markup.head.filter.HeaderResponseContainer#onComponentTagBody() is called too early - before the IHeaderResponse is closed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4396) Impossible to group header
contributions in the
Posted by "Martin Grigorov (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-4396:
------------------------------------
Attachment: WICKET-4396.patch
> Impossible to group header contributions in the <head>
> ------------------------------------------------------
>
> Key: WICKET-4396
> URL: https://issues.apache.org/jira/browse/WICKET-4396
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Attachments: WICKET-4396.patch, WICKET-4396.patch
>
>
> There is a regression in Wicket 6.0 that doesn't allow to have a HeaderResponseContainer in the <head> section.
> It fails because its org.apache.wicket.markup.head.filter.HeaderResponseContainer#onComponentTagBody() is called too early - before the IHeaderResponse is closed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4396) Impossible to group header
contributions in the
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4396.
-------------------------------------
Resolution: Not A Problem
I'll use custom HeaderItem Comparator.
> Impossible to group header contributions in the <head>
> ------------------------------------------------------
>
> Key: WICKET-4396
> URL: https://issues.apache.org/jira/browse/WICKET-4396
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0-beta1
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Attachments: WICKET-4396.patch, WICKET-4396.patch
>
>
> There is a regression in Wicket 6.0 that doesn't allow to have a HeaderResponseContainer in the <head> section.
> It fails because its org.apache.wicket.markup.head.filter.HeaderResponseContainer#onComponentTagBody() is called too early - before the IHeaderResponse is closed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4396) Impossible to group header
contributions in the
Posted by "Martin Grigorov (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-4396:
------------------------------------
Attachment: WICKET-4396.patch
A patch that renders static header (coming from markup: <head> + <wicket:head>) first and then the dynamic header (#renderHead()).
18 tests are failing now...
> Impossible to group header contributions in the <head>
> ------------------------------------------------------
>
> Key: WICKET-4396
> URL: https://issues.apache.org/jira/browse/WICKET-4396
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Attachments: WICKET-4396.patch
>
>
> There is a regression in Wicket 6.0 that doesn't allow to have a HeaderResponseContainer in the <head> section.
> It fails because its org.apache.wicket.markup.head.filter.HeaderResponseContainer#onComponentTagBody() is called too early - before the IHeaderResponse is closed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4396) Impossible to group header
contributions in the
Posted by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203483#comment-13203483 ]
Martin Grigorov commented on WICKET-4396:
-----------------------------------------
Unit tests added to show that it was possible in 1.5: org.apache.wicket.resource.filtering.FilteringHeaderResponseTest#filter()
and now it fails in 6.0: org.apache.wicket.markup.head.filter.FilteringHeaderResponseTest#filter() (Ignored until fixed)
> Impossible to group header contributions in the <head>
> ------------------------------------------------------
>
> Key: WICKET-4396
> URL: https://issues.apache.org/jira/browse/WICKET-4396
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Martin Grigorov
> Assignee: Emond Papegaaij
>
> There is a regression in Wicket 6.0 that doesn't allow to have a HeaderResponseContainer in the <head> section.
> It fails because its org.apache.wicket.markup.head.filter.HeaderResponseContainer#onComponentTagBody() is called too early - before the IHeaderResponse is closed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WICKET-4396) Impossible to group header
contributions in the
Posted by "Martin Grigorov (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-4396:
---------------------------------------
Assignee: Martin Grigorov (was: Emond Papegaaij)
> Impossible to group header contributions in the <head>
> ------------------------------------------------------
>
> Key: WICKET-4396
> URL: https://issues.apache.org/jira/browse/WICKET-4396
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
>
> There is a regression in Wicket 6.0 that doesn't allow to have a HeaderResponseContainer in the <head> section.
> It fails because its org.apache.wicket.markup.head.filter.HeaderResponseContainer#onComponentTagBody() is called too early - before the IHeaderResponse is closed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira