Re: [PR] feat: Add support for round-robin partitioning in native shuffle [datafusion-comet]

["mbutrovich (via GitHub)" <gi...@apache.org>]

mbutrovich commented on code in PR #3076:
URL: https://github.com/apache/datafusion-comet/pull/3076#discussion_r2694701515


##########
docs/source/contributor-guide/native_shuffle.md:
##########
@@ -187,6 +186,18 @@ For range partitioning:
 The simplest case: all rows go to partition 0. Uses `SinglePartitionShufflePartitioner` which
 simply concatenates batches to reach the configured batch size.
 
+### Round Robin Partitioning
+
+Round robin partitioning distributes rows evenly across partitions in a deterministic way:
+
+1. Computes a Murmur3 hash of **all columns** in each row (using seed 42)
+2. Sorts rows by their hash values to ensure deterministic ordering

Review Comment:
   This step is not true for Comet, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org