You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by gi...@git.apache.org on 2017/08/10 03:40:46 UTC

[GitHub] filmaj opened a new pull request #330: CB-13164: Integrated cordova-plugin-console

filmaj opened a new pull request #330: CB-13164: Integrated cordova-plugin-console
URL: https://github.com/apache/cordova-ios/pull/330
 
 
   ### What does this PR do?
   
   Adds support for `window.console` to be built in to generated cordova-ios projects. Essentially: sunsetting [cordova-plugin-console](https://github.com/apache/cordova-plugin-console) and integrating its iOS bits into cordova-ios.
   
   - added native source files for CDVLogger
   - updated pbxproj file for CordovaLib to take the new files into account
   
   ### What testing has been done on this change?
   
   Just `npm test` locally on my Mac. Unsure if I should add any additional tests? @shazron leaning on you for guidance on that question.
   
   ### Checklist
   - [x] [Reported issue CB-13147](https://issues.apache.org/jira/browse/CB-13147)
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org