You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@juneau.apache.org by "Surya00011 (via GitHub)" <gi...@apache.org> on 2025/08/23 05:47:13 UTC
[PR] Fix RestOptions annotation context apply [juneau]
Surya00011 opened a new pull request, #236:
URL: https://github.com/apache/juneau/pull/236
##Description
- This PR fixes a bug where the ```@RestOptions``` annotation was incorrectly referencing RestGetAnnotation.RestOpContextApply, causing a ClassCastException when handling OPTIONS requests.
## Changes made:
- Updated RestOptions.java to use RestOptionsAnnotation.RestOpContextApply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@juneau.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix RestOptions annotation context apply [juneau]
Posted by "Surya00011 (via GitHub)" <gi...@apache.org>.
Surya00011 closed pull request #236: Fix RestOptions annotation context apply
URL: https://github.com/apache/juneau/pull/236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@juneau.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix RestOptions annotation context apply [juneau]
Posted by "Surya00011 (via GitHub)" <gi...@apache.org>.
Surya00011 commented on PR #236:
URL: https://github.com/apache/juneau/pull/236#issuecomment-3216972130
Hi @jamesbognar, any comments on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@juneau.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix RestOptions annotation context apply [juneau]
Posted by "Surya00011 (via GitHub)" <gi...@apache.org>.
Surya00011 commented on PR #236:
URL: https://github.com/apache/juneau/pull/236#issuecomment-3218267878
Hi @jamesbognar ,
## Update
I closed the earlier PR and pushed again after updating my Git config to avoid newline conversion issues. I ran: ``` git config --global core.autocrlf input```
so LF is kept as-is from the repo. After that, I changed only the intended line and committed again.
But the diff still shows the entire `RestOptions` file as modified. I tried this on both Windows and Linux and the issue remains the same, so I’m not sure why it still happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@juneau.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix RestOptions annotation context apply [juneau]
Posted by "jamesbognar (via GitHub)" <gi...@apache.org>.
jamesbognar commented on PR #236:
URL: https://github.com/apache/juneau/pull/236#issuecomment-3218257730
Not sure why this was closed, but I applied the fix anyway. Thanks @Surya00011 !
@garydgregory - I think the newlines changed which is why the entire file looked like it got modified. There's an option on the PR page settings to ignore whitespace when this happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@juneau.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org