You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Dongjoon Hyun (JIRA)" <ji...@apache.org> on 2019/07/21 20:35:00 UTC
[jira] [Assigned] (SPARK-28462) Add a prefix '*' to non-nullable
attribute names in PlanTestBase.comparePlans failures
[ https://issues.apache.org/jira/browse/SPARK-28462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dongjoon Hyun reassigned SPARK-28462:
-------------------------------------
Assignee: Takeshi Yamamuro
> Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures
> --------------------------------------------------------------------------------------
>
> Key: SPARK-28462
> URL: https://issues.apache.org/jira/browse/SPARK-28462
> Project: Spark
> Issue Type: Test
> Components: SQL
> Affects Versions: 3.0.0
> Reporter: Takeshi Yamamuro
> Assignee: Takeshi Yamamuro
> Priority: Major
>
> This ticket proposes to add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures. In the current master, nullability mismatches might generate the same error message for left/right logical plans like this;
> {code}
> // This failure message was extracted from #24765
> - constraints should be inferred from aliased literals *** FAILED ***
> == FAIL: Plans do not match ===
> !'Join Inner, (two#0 = a#0) 'Join Inner, (two#0 = a#0)
> :- Filter (isnotnull(a#0) AND (2 <=> a#0)) :- Filter (isnotnull(a#0) AND (2 <=> a#0))
> : +- LocalRelation <empty>, [a#0, b#0, c#0] : +- LocalRelation <empty>, [a#0, b#0, c#0]
> +- Project [2 AS two#0] +- Project [2 AS two#0]
> +- LocalRelation <empty>, [a#0, b#0, c#0] +- LocalRelation <empty>, [a#0, b#0, c#0] (PlanTest.scala:145)
> {code}
> This ticket intends to change this error message to one below;
> {code}
> - constraints should be inferred from aliased literals *** FAILED ***
> == FAIL: Plans do not match ===
> !'Join Inner, (*two#0 = a#0) 'Join Inner, (*two#0 = *a#0)
> :- Filter (isnotnull(a#0) AND (2 <=> a#0)) :- Filter (isnotnull(a#0) AND (2 <=> a#0))
> : +- LocalRelation <empty>, [a#0, b#0, c#0] : +- LocalRelation <empty>, [a#0, b#0, c#0]
> +- Project [2 AS two#0] +- Project [2 AS two#0]
> +- LocalRelation <empty>, [a#0, b#0, c#0] +- LocalRelation <empty>, [a#0, b#0, c#0] (PlanTest.scala:145)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org