[GitHub] [superset] stephenLYZ commented on a change in pull request #17917: feat(plugin-chart-echarts): support non-timeseries x-axis

[GitBox <gi...@apache.org>]

stephenLYZ commented on a change in pull request #17917:
URL: https://github.com/apache/superset/pull/17917#discussion_r781974069



##########
File path: superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.tsx
##########
@@ -130,7 +130,9 @@ export default function EchartsTimeseries({
       }
       // Ensure that double-click events do not trigger single click event. So we put it in the timer.
       clickTimer.current = setTimeout(() => {
-        const { seriesName: name } = props;
+        const { seriesName: name, value } = props;
+        const xValue = value[0].getTime?.() || value[0];
+        console.log(xValue);

Review comment:
       we can remove it if this log is not needed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org