You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/16 17:57:21 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #7455: ARROW-9031: [R] Implement conversion from Type::UINT64 to R vector

pitrou commented on a change in pull request #7455:
URL: https://github.com/apache/arrow/pull/7455#discussion_r441038280



##########
File path: r/tests/testthat/test-Array.R
##########
@@ -385,6 +385,14 @@ test_that("Array<int8>$as_vector() converts to integer (ARROW-3794)", {
   expect_equal(a$as_vector(), 0:255)
 })
 
+test_that("Arrays of uint{32,64} convert to numeric", {
+  u32 <- Array$create(1L)$cast(uint32())
+  expect_identical(as.vector(u32), 1)
+
+  u64 <- Array$create(1L)$cast(uint64())
+  expect_identical(as.vector(u64), 1)
+})

Review comment:
       Those tests are thorough!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org