You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Stipe Tolj <to...@wapme-systems.de> on 2001/09/21 15:35:15 UTC
[PATCH] 1.3: serialized accept for Cygwin OS
Apache for Cygwin is currently broken because of no
HAVE_*_SERIALIZED_ACCEPT #defines within src/include/ap_config.h, so
here are a couple of Cygwin specific changes. Please commit changes to
CVS.
Here is what has been changed:
* src/include/ap_config.h: added two #define statements to support
serialized accept on Cygwin too.
* src/helpers/install.sh: Martin added the last time to much
concerning the ".exe" extension detection while "make install", which
in fact then did not work. This will work and has no impact on other
OS.
* src/Configure: made a slight change to Cygwin specific LD_SHLIB
definition.
* htdocs/manual/cygwin.html: added a couple of extra information
that should be usefull for anyone attempting to compile using shared
DLLs.
Stipe
tolj@wapme-systems.de
-------------------------------------------------------------------
Wapme Systems AG
Münsterstr. 248
40470 Düsseldorf
Tel: +49-211-74845-0
Fax: +49-211-74845-299
E-Mail: info@wapme-systems.de
Internet: http://www.wapme-systems.de
-------------------------------------------------------------------
wapme.net - wherever you are
Re: [PATCH] 1.3: serialized accept for Cygwin OS
Posted by Jim Jagielski <ji...@jaguNET.com>.
Thanks! I'll commit these today
--
===========================================================================
Jim Jagielski [|] jim@jaguNET.com [|] http://www.jaguNET.com/
"A society that will trade a little liberty for a little order
will lose both and deserve neither"
Re: [PATCH] 1.3: serialized accept for Cygwin OS
Posted by Stipe Tolj <to...@wapme-systems.de>.
Hi Martin,
> The idea was to make sure that .exe was assumed ONLY in the case that
> no file _without_ .exe had been created. If both exist, then I don't
> want to automatically assume that .exe is the default extension.
>
> By removing the code above, you would do just that: favor .exe over
> "no extension" if both cases are found.
>
> Originally, I coded that as [ -f "$src.exe" ] && [ ! -f "$src" ] but
> you told me that Cygwin's "test" is to dumb to grok this syntax.
>
> Thus let's keep it the way it is. (Thanks, Jim!)
AFAIK, the code would have no inpact on over OS?! And as Cygwin does
not create executables (at least from ld) "without" .exe extension I
would prefer the change.
The problem is that both operands of the arbitary AND operaion are
true on Cygwin 1.x, even if there physicaly only exists $src.exe.
Stipe
tolj@wapme-systems.de
-------------------------------------------------------------------
Wapme Systems AG
Münsterstr. 248
40470 Düsseldorf
Tel: +49-211-74845-0
Fax: +49-211-74845-299
E-Mail: info@wapme-systems.de
Internet: http://www.wapme-systems.de
-------------------------------------------------------------------
wapme.net - wherever you are
Re: [PATCH] 1.3: serialized accept for Cygwin OS
Posted by Martin Kraemer <Ma...@Fujitsu-Siemens.com>.
On Fri, Sep 21, 2001 at 03:35:15PM +0200, Stipe Tolj wrote:
> * src/helpers/install.sh: Martin added the last time to much
> concerning the ".exe" extension detection while "make install", which
> in fact then did not work. This will work and has no impact on other
> OS.
>
> diff -ur apache-1.3/src/helpers/install.sh apache-1.3-cygwin/src/helpers/install.sh
> --- apache-1.3/src/helpers/install.sh Tue Jun 12 10:24:53 2001
> +++ apache-1.3-cygwin/src/helpers/install.sh Fri Sep 21 12:54:06 2001
> @@ -88,13 +88,10 @@
> fi
>
> # Check if we need to add an executable extension (such as ".exe")
> -# on specific OS to src and dst
> +# on specific OS to src and dst.
> +# At least Cygwin requires this to ensure a clean "make install".
> if [ -f "$src.exe" ]; then
> - if [ -f "$src" ]; then
> - : # Cygwin [ test ] is too stupid to do [ -f "$src.exe" ] && [ ! -f "$src" ]
> - else
> ext=".exe"
> - fi
> fi
> src="$src$ext"
> dst="$dst$ext"
The idea was to make sure that .exe was assumed ONLY in the case that
no file _without_ .exe had been created. If both exist, then I don't
want to automatically assume that .exe is the default extension.
By removing the code above, you would do just that: favor .exe over
"no extension" if both cases are found.
Originally, I coded that as [ -f "$src.exe" ] && [ ! -f "$src" ] but
you told me that Cygwin's "test" is to dumb to grok this syntax.
Thus let's keep it the way it is. (Thanks, Jim!)
Martin
--
<Ma...@Fujitsu-Siemens.com> | Fujitsu Siemens
Fon: +49-89-636-46021, FAX: +49-89-636-47655 | 81730 Munich, Germany