You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2015/12/02 01:40:11 UTC

[jira] [Created] (HBASE-14902) Revert some of the stringency recently introduced by checkstyle tightening

stack created HBASE-14902:
-----------------------------

             Summary: Revert some of the stringency recently introduced by checkstyle tightening
                 Key: HBASE-14902
                 URL: https://issues.apache.org/jira/browse/HBASE-14902
             Project: HBase
          Issue Type: Sub-task
            Reporter: stack


I think we should undo some of the plugins that were recently added to checkstyle. They are too much.

JavadocTagContinuationIndentationCheck is about adding indent if javadoc is two lines or more (javadoc tool doesn't care)

NonEmptyAtclauseDescriptionCheck would have us add javadoc on each exception: e.g. @throws IOException needs to have text added.

NeedBracesCheck has us undoing cases where an if fits all on one line (don't want to start style wars but if short and fits on one line, I think its more readable... but I could relent on this one.... ).

The first two at least should go.

You ok w/ that [~appy]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)