You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/24 05:51:36 UTC
[GitHub] [shardingsphere] tuichenchuxin opened a new pull request #16330: fix encrypt column data type ci error in commercial version.
tuichenchuxin opened a new pull request #16330:
URL: https://github.com/apache/shardingsphere/pull/16330
fix encrypt column data type ci error in commercial version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuichenchuxin commented on a change in pull request #16330: Refactor encrypt test use moked datasource with `metaData.getTypeInfo()`.
Posted by GitBox <gi...@apache.org>.
tuichenchuxin commented on a change in pull request #16330:
URL: https://github.com/apache/shardingsphere/pull/16330#discussion_r835999556
##########
File path: shardingsphere-test/shardingsphere-rewrite-test/src/test/java/org/apache/shardingsphere/sharding/rewrite/parameterized/engine/AbstractSQLRewriterParameterizedTest.java
##########
@@ -120,6 +122,9 @@ public final void assertRewrite() throws IOException {
? Collections.singletonList(((GenericSQLRewriteResult) sqlRewriteResult).getSqlRewriteUnit()) : (((RouteSQLRewriteResult) sqlRewriteResult).getSqlRewriteUnits()).values();
}
+ protected void mockDataSource(final Map<String, DataSource> dataSources) throws SQLException {
Review comment:
Thank you. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #16330: Refactor encrypt test use moked datasource with `metaData.getTypeInfo()`.
Posted by GitBox <gi...@apache.org>.
strongduanmu merged pull request #16330:
URL: https://github.com/apache/shardingsphere/pull/16330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #16330: Refactor encrypt test use moked datasource with `metaData.getTypeInfo()`.
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on a change in pull request #16330:
URL: https://github.com/apache/shardingsphere/pull/16330#discussion_r834164592
##########
File path: shardingsphere-test/shardingsphere-rewrite-test/src/test/java/org/apache/shardingsphere/sharding/rewrite/parameterized/engine/AbstractSQLRewriterParameterizedTest.java
##########
@@ -120,6 +122,9 @@ public final void assertRewrite() throws IOException {
? Collections.singletonList(((GenericSQLRewriteResult) sqlRewriteResult).getSqlRewriteUnit()) : (((RouteSQLRewriteResult) sqlRewriteResult).getSqlRewriteUnits()).values();
}
+ protected void mockDataSource(final Map<String, DataSource> dataSources) throws SQLException {
Review comment:
@tuichenchuxin Please make mockDataSource abstract.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org