[GitHub] [daffodil] jadams-tresys commented on a diff in pull request #967: Consider ChoiceGroupRef's open when determining next elements

["jadams-tresys (via GitHub)" <gi...@apache.org>]

jadams-tresys commented on code in PR #967:
URL: https://github.com/apache/daffodil/pull/967#discussion_r1113404377


##########
daffodil-core/src/main/scala/org/apache/daffodil/core/runtime1/TermRuntime1Mixin.scala:
##########
@@ -354,8 +355,12 @@ trait TermRuntime1Mixin { self: Term =>
           case (Closed(pnes1), Closed(pnes2)) => {
             thisItself // When everything is closed, we only want thisItself and not the entire list of Closed possibilities
           }
-          case (Open(pnes1), Closed(pnes2)) => {
+          case (Open(pnes1), Closed(pnes2)) if !this.isInstanceOf[ChoiceGroupRef] => {

Review Comment:
   I can seen an argument to be made here that this logic should actually be part of SeveralPossibilitiesForNextElement in PartialNextElementResolver for when we are determining if the element is actually required or not.  Figured I'd leave it up for discussion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org