You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Rohini Palaniswamy <ro...@gmail.com> on 2014/05/01 02:17:13 UTC
Re: Review Request 18762: OOZIE-1709 CoordELFunctions.getCurrentInstance()
is expensive
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18762/#review41896
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On April 21, 2014, 7:02 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18762/
> -----------------------------------------------------------
>
> (Updated April 21, 2014, 7:02 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1709
> https://issues.apache.org/jira/browse/OOZIE-1709
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> CoordELFunctions.getCurrentInstance() has this code:
> while (current.compareTo(calEffectiveTime) <= 0) {
> current = (Calendar) origCurrent.clone();
> instanceCount[0]++;
> current.add(dsTimeUnit.getCalendarUnit(), instanceCount[0] * dsFreq);
> }
>
> For coords with smaller frequency and start time in very past, this is very expensive. On prod, we have seen materialisation of each instance taking few mins sometimes for coords with 1 min frequency
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java d73bc7d
> core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java be35ce4
>
> Diff: https://reviews.apache.org/r/18762/diff/
>
>
> Testing
> -------
>
> UT
>
>
> Thanks,
>
> shwethags
>
>