You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/01 18:58:48 UTC

[GitHub] [flink] bowenli86 opened a new pull request #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog

bowenli86 opened a new pull request #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog
URL: https://github.com/apache/flink/pull/8589
 
 
   ## What is the purpose of the change
   
   This PR adds descriptor, validator, and factory for HiveCatalog, and tests  in flink-sql-client.
   
   Design doc can be [found here](https://docs.google.com/document/d/1ALxfiGZBaZ8KUNJtoT443hReoPoJEdt9Db2wiJ2LuWA/edit).
   
   ## Brief change log
   
   - added descriptor, validator, and factory for HiveCatalog
   - added unit tests in both flink-connector-hive and flnk-sql-client. Factory discovery service tests in flink-sql-client uses`TestHiveCatalog` and `TestHiveCatalogFactory`, and these classes are mostly exactly the same with `HiveCatalog` and `HiveCatalogFactory` except a few minimal differences for testing purpose.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - added `HiveCatalogDescriptorTest` and `HiveCatalogFactoryTest` in flink-connector-hive
   - added `TestHiveCatalog` and `TestHiveCatalogFactory`in flink-sql-client along with hive catalog entries in test-sql-client-catalogs.yaml for test factory discovery.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes )
     - If yes, how is the feature documented? (docs)
   
   Docs will be added later on.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services