You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by marmbrus <gi...@git.apache.org> on 2014/12/02 01:03:27 UTC

[GitHub] spark pull request: [SPARK-4573] [SQL] Add SettableStructObjectIns...

Github user marmbrus commented on the pull request:

    https://github.com/apache/spark/pull/3429#issuecomment-65161722
  
    Thanks for working on this and adding a bunch of tests.  All of this is getting pretty complicated, so I think it would be good if you could add some more explanation to the scala doc of wrap/unwrap that discusses what types object inspectors exist and which will be returned for what type of expression.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org