[GitHub] [inlong] liangyepianzhou commented on a diff in pull request #5879: [INLONG-5133][Sort] Support influxDB sink for sort

[GitBox <gi...@apache.org>]

liangyepianzhou commented on code in PR #5879:
URL: https://github.com/apache/inlong/pull/5879#discussion_r972589473


##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/LoadNode.java:
##########
@@ -72,7 +73,8 @@
         @JsonSubTypes.Type(value = OracleLoadNode.class, name = "oracleLoad"),
         @JsonSubTypes.Type(value = GreenplumLoadNode.class, name = "greenplumLoad"),
         @JsonSubTypes.Type(value = DLCIcebergLoadNode.class, name = "dlcIcebergLoad"),
-        @JsonSubTypes.Type(value = DorisLoadNode.class, name = "dorisLoad")
+        @JsonSubTypes.Type(value = DorisLoadNode.class, name = "dorisLoad"),
+        @JsonSubTypes.Type(value = InfluxDBLoadNode.class, name = "influxdb")

Review Comment:
   1. Name changes done.
   2.` the package of jdbc/src/main... should not be under sort-connectors.`, do you mean `the package of influxdb-jdbc/src/main`. And please explain why this is wrong.
   3. this CDC sues JDBC table API: `options.put("connector", "jdbc-inlong");`
   4. @jun0315  is already testing the referenced influx-jdbc-driver connector



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org