You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2015/11/04 18:16:40 UTC
Review Request 39941: SIGPIPE is ignored in libprocess so stop
handling it.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39941/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-2079
https://issues.apache.org/jira/browse/MESOS-2079
Repository: mesos
Description
-------
SIGPIPE is ignored in libprocess so stop handling it.
Diffs
-----
src/logging/logging.cpp fb798670d9ac79c75ad39905614fbfe1ea25fba6
src/tests/main.cpp 970a8b06e1c04cb6545353c8d36f5707c153d49b
Diff: https://reviews.apache.org/r/39941/diff/
Testing
-------
make check.
Run IOTest.Write in a loop on OS X.
Thanks,
James Peach
Re: Review Request 39941: SIGPIPE is ignored in libprocess so stop
handling it.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39941/#review105087
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Nov. 4, 2015, 5:16 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39941/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 5:16 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2079
> https://issues.apache.org/jira/browse/MESOS-2079
>
>
> Repository: mesos
>
>
> Description
> -------
>
> SIGPIPE is ignored in libprocess so stop handling it.
>
>
> Diffs
> -----
>
> src/logging/logging.cpp fb798670d9ac79c75ad39905614fbfe1ea25fba6
> src/tests/main.cpp 970a8b06e1c04cb6545353c8d36f5707c153d49b
>
> Diff: https://reviews.apache.org/r/39941/diff/
>
>
> Testing
> -------
>
> make check.
> Run IOTest.Write in a loop on OS X.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 39941: SIGPIPE is ignored in libprocess so stop
handling it.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39941/#review105119
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39938, 39940, 39941]
All tests passed.
- Mesos ReviewBot
On Nov. 4, 2015, 5:16 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39941/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 5:16 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2079
> https://issues.apache.org/jira/browse/MESOS-2079
>
>
> Repository: mesos
>
>
> Description
> -------
>
> SIGPIPE is ignored in libprocess so stop handling it.
>
>
> Diffs
> -----
>
> src/logging/logging.cpp fb798670d9ac79c75ad39905614fbfe1ea25fba6
> src/tests/main.cpp 970a8b06e1c04cb6545353c8d36f5707c153d49b
>
> Diff: https://reviews.apache.org/r/39941/diff/
>
>
> Testing
> -------
>
> make check.
> Run IOTest.Write in a loop on OS X.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 39941: SIGPIPE is ignored in libprocess so stop
handling it.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39941/#review108933
-----------------------------------------------------------
Ship it!
Looks great, thanks!
src/tests/main.cpp (line 19)
<https://reviews.apache.org/r/39941/#comment168385>
No longer needed?
src/tests/main.cpp (line 32)
<https://reviews.apache.org/r/39941/#comment168386>
No longer needed?
- Ben Mahler
On Nov. 4, 2015, 5:16 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39941/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 5:16 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2079
> https://issues.apache.org/jira/browse/MESOS-2079
>
>
> Repository: mesos
>
>
> Description
> -------
>
> SIGPIPE is ignored in libprocess so stop handling it.
>
>
> Diffs
> -----
>
> src/logging/logging.cpp fb798670d9ac79c75ad39905614fbfe1ea25fba6
> src/tests/main.cpp 970a8b06e1c04cb6545353c8d36f5707c153d49b
>
> Diff: https://reviews.apache.org/r/39941/diff/
>
>
> Testing
> -------
>
> make check.
> Run IOTest.Write in a loop on OS X.
>
>
> Thanks,
>
> James Peach
>
>