You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by lc...@apache.org on 2016/04/21 18:10:03 UTC

[1/2] incubator-beam git commit: Remove use of System.currentTimeMillis in Flink Test

Repository: incubator-beam
Updated Branches:
  refs/heads/master dba1a349c -> 0e420f16c


Remove use of System.currentTimeMillis in Flink Test

This will stop tests failing if the DoFn executes within ~25 seconds of
an hour boundary.


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/277885ce
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/277885ce
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/277885ce

Branch: refs/heads/master
Commit: 277885ced0b04e7f0db50cf1a5927dde3588c390
Parents: dba1a34
Author: Thomas Groh <tg...@google.com>
Authored: Tue Apr 19 09:39:38 2016 -0700
Committer: Luke Cwik <lc...@google.com>
Committed: Thu Apr 21 09:07:57 2016 -0700

----------------------------------------------------------------------
 .../apache/beam/runners/flink/streaming/GroupByNullKeyTest.java   | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/277885ce/runners/flink/runner/src/test/java/org/apache/beam/runners/flink/streaming/GroupByNullKeyTest.java
----------------------------------------------------------------------
diff --git a/runners/flink/runner/src/test/java/org/apache/beam/runners/flink/streaming/GroupByNullKeyTest.java b/runners/flink/runner/src/test/java/org/apache/beam/runners/flink/streaming/GroupByNullKeyTest.java
index 9f7bd90..1b55c61 100644
--- a/runners/flink/runner/src/test/java/org/apache/beam/runners/flink/streaming/GroupByNullKeyTest.java
+++ b/runners/flink/runner/src/test/java/org/apache/beam/runners/flink/streaming/GroupByNullKeyTest.java
@@ -67,12 +67,11 @@ public class GroupByNullKeyTest extends StreamingProgramTestBase implements Seri
     @Override
     public void processElement(ProcessContext c) {
       KV<Integer, String> record = c.element();
-      long now = System.currentTimeMillis();
       int timestamp = record.getKey();
       String userName = record.getValue();
       if (userName != null) {
         // Sets the implicit timestamp field to be used in windowing.
-        c.outputWithTimestamp(userName, new Instant(timestamp + now));
+        c.outputWithTimestamp(userName, new Instant(timestamp));
       }
     }
   }


[2/2] incubator-beam git commit: [BEAM-208] This closes #210

Posted by lc...@apache.org.
[BEAM-208] This closes #210


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/0e420f16
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/0e420f16
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/0e420f16

Branch: refs/heads/master
Commit: 0e420f16ce3b8a2a1ae30c52db4e092b260d87b0
Parents: dba1a34 277885c
Author: Luke Cwik <lc...@google.com>
Authored: Thu Apr 21 09:08:33 2016 -0700
Committer: Luke Cwik <lc...@google.com>
Committed: Thu Apr 21 09:08:33 2016 -0700

----------------------------------------------------------------------
 .../apache/beam/runners/flink/streaming/GroupByNullKeyTest.java   | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------