You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Murali Ramasami <mu...@gmail.com> on 2016/01/07 09:33:31 UTC
Review Request 42020: [FALCON-1701] HiveDr, ClusterSetupTest,
MirrorSummaryTest fixes provided by Murali Ramasami
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42020/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1701
https://issues.apache.org/jira/browse/FALCON-1701
Repository: falcon-git
Description
-------
HiveDr, ClusterSetupTest, MirrorSummaryTest fixes provided by Murali Ramasami
Diffs
-----
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java f19fc23
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java 27417bd
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java e0b69e1
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSummaryTest.java 0a788f0
falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml c644b99
falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-workflow.xml aa4d5b0
falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery.properties 99f748d
falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-template.xml 3afbef0
falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml c441998
falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery.properties de7f7f9
falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-template.xml 3afbef0
falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-workflow.xml 7362c2e
falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure.properties ff2611f
Diff: https://reviews.apache.org/r/42020/diff/
Testing
-------
tested on nightly runs
Thanks,
Murali Ramasami
Re: Review Request 42020: [FALCON-1701] HiveDr, ClusterSetupTest,
MirrorSummaryTest fixes provided by Murali Ramasami
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42020/#review113704
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On Jan. 11, 2016, 5:29 a.m., Murali Ramasami wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42020/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 5:29 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1701
> https://issues.apache.org/jira/browse/FALCON-1701
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> HiveDr, ClusterSetupTest, MirrorSummaryTest fixes provided by Murali Ramasami
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java f19fc23
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java 27417bd
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java e0b69e1
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSummaryTest.java 0a788f0
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml c644b99
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-workflow.xml aa4d5b0
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery.properties 99f748d
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-template.xml 3afbef0
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml c441998
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery.properties de7f7f9
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-template.xml 3afbef0
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-workflow.xml 7362c2e
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure.properties ff2611f
>
> Diff: https://reviews.apache.org/r/42020/diff/
>
>
> Testing
> -------
>
> tested on nightly runs
>
>
> Thanks,
>
> Murali Ramasami
>
>
Re: Review Request 42020: [FALCON-1701] HiveDr, ClusterSetupTest,
MirrorSummaryTest fixes provided by Murali Ramasami
Posted by Murali Ramasami <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42020/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 5:29 a.m.)
Review request for Falcon.
Changes
-------
Fixed the Checkstyle Error.
Bugs: FALCON-1701
https://issues.apache.org/jira/browse/FALCON-1701
Repository: falcon-git
Description
-------
HiveDr, ClusterSetupTest, MirrorSummaryTest fixes provided by Murali Ramasami
Diffs (updated)
-----
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java f19fc23
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java 27417bd
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java e0b69e1
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSummaryTest.java 0a788f0
falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml c644b99
falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-workflow.xml aa4d5b0
falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery.properties 99f748d
falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-template.xml 3afbef0
falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml c441998
falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery.properties de7f7f9
falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-template.xml 3afbef0
falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-workflow.xml 7362c2e
falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure.properties ff2611f
Diff: https://reviews.apache.org/r/42020/diff/
Testing
-------
tested on nightly runs
Thanks,
Murali Ramasami
Re: Review Request 42020: [FALCON-1701] HiveDr, ClusterSetupTest,
MirrorSummaryTest fixes provided by Murali Ramasami
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42020/#review113248
-----------------------------------------------------------
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java (line 325)
<https://reviews.apache.org/r/42020/#comment173759>
Checkstyle failure: trailing whitespace.
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java (line 338)
<https://reviews.apache.org/r/42020/#comment173758>
Checkstyle failure: variable value has been declared twice within the method getSummary(..)
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java (line 412)
<https://reviews.apache.org/r/42020/#comment173757>
Checkstyle failure: Variable value has been declared twice. Once here and once above.
- Ajay Yadava
On Jan. 7, 2016, 8:33 a.m., Murali Ramasami wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42020/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 8:33 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1701
> https://issues.apache.org/jira/browse/FALCON-1701
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> HiveDr, ClusterSetupTest, MirrorSummaryTest fixes provided by Murali Ramasami
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java f19fc23
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java 27417bd
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java e0b69e1
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSummaryTest.java 0a788f0
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml c644b99
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-workflow.xml aa4d5b0
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery.properties 99f748d
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-template.xml 3afbef0
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml c441998
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery.properties de7f7f9
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-template.xml 3afbef0
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-workflow.xml 7362c2e
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure.properties ff2611f
>
> Diff: https://reviews.apache.org/r/42020/diff/
>
>
> Testing
> -------
>
> tested on nightly runs
>
>
> Thanks,
>
> Murali Ramasami
>
>
Re: Review Request 42020: [FALCON-1701] HiveDr, ClusterSetupTest,
MirrorSummaryTest fixes provided by Murali Ramasami
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42020/#review113229
-----------------------------------------------------------
Ship it!
Ship It!
- PRAGYA MITTAL
On Jan. 7, 2016, 8:33 a.m., Murali Ramasami wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42020/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 8:33 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1701
> https://issues.apache.org/jira/browse/FALCON-1701
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> HiveDr, ClusterSetupTest, MirrorSummaryTest fixes provided by Murali Ramasami
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java f19fc23
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java 27417bd
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java e0b69e1
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSummaryTest.java 0a788f0
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml c644b99
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-workflow.xml aa4d5b0
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery.properties 99f748d
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-template.xml 3afbef0
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml c441998
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery.properties de7f7f9
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-template.xml 3afbef0
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-workflow.xml 7362c2e
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure.properties ff2611f
>
> Diff: https://reviews.apache.org/r/42020/diff/
>
>
> Testing
> -------
>
> tested on nightly runs
>
>
> Thanks,
>
> Murali Ramasami
>
>
Re: Review Request 42020: [FALCON-1701] HiveDr, ClusterSetupTest,
MirrorSummaryTest fixes provided by Murali Ramasami
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42020/#review113226
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On Jan. 7, 2016, 8:33 a.m., Murali Ramasami wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42020/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 8:33 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1701
> https://issues.apache.org/jira/browse/FALCON-1701
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> HiveDr, ClusterSetupTest, MirrorSummaryTest fixes provided by Murali Ramasami
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java f19fc23
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java 27417bd
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java e0b69e1
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSummaryTest.java 0a788f0
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml c644b99
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-workflow.xml aa4d5b0
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery.properties 99f748d
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-template.xml 3afbef0
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml c441998
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery.properties de7f7f9
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-template.xml 3afbef0
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-workflow.xml 7362c2e
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure.properties ff2611f
>
> Diff: https://reviews.apache.org/r/42020/diff/
>
>
> Testing
> -------
>
> tested on nightly runs
>
>
> Thanks,
>
> Murali Ramasami
>
>
Re: Review Request 42020: [FALCON-1701] HiveDr, ClusterSetupTest,
MirrorSummaryTest fixes provided by Murali Ramasami
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42020/#review113249
-----------------------------------------------------------
There are some checkstyle failures, because of which the patch doesn't apply cleanly. You can check your patch for checkstyle by running the following command:
mvn clean install -Ptest-patch,hadoop-2 -DskipTests
- Ajay Yadava
On Jan. 7, 2016, 8:33 a.m., Murali Ramasami wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42020/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 8:33 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1701
> https://issues.apache.org/jira/browse/FALCON-1701
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> HiveDr, ClusterSetupTest, MirrorSummaryTest fixes provided by Murali Ramasami
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java f19fc23
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java 27417bd
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java e0b69e1
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSummaryTest.java 0a788f0
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml c644b99
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-workflow.xml aa4d5b0
> falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery.properties 99f748d
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-template.xml 3afbef0
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery-workflow.xml c441998
> falcon-regression/merlin/src/test/resources/HiveDrRecipe/hive-disaster-recovery.properties de7f7f9
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-template.xml 3afbef0
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure-workflow.xml 7362c2e
> falcon-regression/merlin/src/test/resources/HiveDrSecureRecipe/hive-disaster-recovery-secure.properties ff2611f
>
> Diff: https://reviews.apache.org/r/42020/diff/
>
>
> Testing
> -------
>
> tested on nightly runs
>
>
> Thanks,
>
> Murali Ramasami
>
>