You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/03 21:21:38 UTC
[GitHub] [airflow] dstandish opened a new pull request, #23461: Log info when pre upgrade checks
dstandish opened a new pull request, #23461:
URL: https://github.com/apache/airflow/pull/23461
Let users know what's happening when pre-migration checks are running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #23461: Log info when pre upgrade checks
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #23461:
URL: https://github.com/apache/airflow/pull/23461#discussion_r864274680
##########
airflow/utils/db.py:
##########
@@ -1282,6 +1287,7 @@ def _check_migration_errors(session: Session = NEW_SESSION) -> Iterable[str]:
check_bad_references,
)
for check_fn in check_functions:
+ log.info("running pre-migration check %s", check_fn.__name__)
Review Comment:
This is the one I'm not sure about - if the check is a no-op (which it should be for most of the time once it's run once?) then isn't this just noise?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish closed pull request #23461: Log info when pre upgrade checks
Posted by GitBox <gi...@apache.org>.
dstandish closed pull request #23461: Log info when pre upgrade checks
URL: https://github.com/apache/airflow/pull/23461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #23461: Log info when pre upgrade checks
Posted by GitBox <gi...@apache.org>.
dstandish commented on PR #23461:
URL: https://github.com/apache/airflow/pull/23461#issuecomment-1117667424
> Nit: Capitalize the first words?
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a diff in pull request #23461: Log info when pre upgrade checks
Posted by GitBox <gi...@apache.org>.
dstandish commented on code in PR #23461:
URL: https://github.com/apache/airflow/pull/23461#discussion_r865070839
##########
airflow/utils/db.py:
##########
@@ -1282,6 +1287,7 @@ def _check_migration_errors(session: Session = NEW_SESSION) -> Iterable[str]:
check_bad_references,
)
for check_fn in check_functions:
+ log.info("running pre-migration check %s", check_fn.__name__)
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23461: Log info when pre upgrade checks
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23461:
URL: https://github.com/apache/airflow/pull/23461#issuecomment-1117610987
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a diff in pull request #23461: Log info when pre upgrade checks
Posted by GitBox <gi...@apache.org>.
dstandish commented on code in PR #23461:
URL: https://github.com/apache/airflow/pull/23461#discussion_r865143685
##########
airflow/utils/db.py:
##########
@@ -1237,11 +1237,14 @@ class BadReferenceConfig:
if "run_id" in source_table.columns:
continue
+ log.info("checking for bad references in table %s", source_table.name)
Review Comment:
```suggestion
log.info("Checking for bad references in table %s", source_table.name)
```
##########
airflow/utils/db.py:
##########
@@ -1237,11 +1237,14 @@ class BadReferenceConfig:
if "run_id" in source_table.columns:
continue
+ log.info("checking for bad references in table %s", source_table.name)
+
bad_rows_subquery = bad_ref_cfg.exists_func(session, source_table, **exists_func_kwargs)
select_list = [x.label(x.name) for x in source_table.c]
invalid_rows_query = session.query(*select_list).filter(~bad_rows_subquery.exists())
invalid_row_count = invalid_rows_query.count()
if invalid_row_count <= 0:
+ log.info("no bad references in table %s", source_table.name)
Review Comment:
```suggestion
log.info("No bad references in table %s", source_table.name)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a diff in pull request #23461: Log info when pre upgrade checks
Posted by GitBox <gi...@apache.org>.
dstandish commented on code in PR #23461:
URL: https://github.com/apache/airflow/pull/23461#discussion_r865071187
##########
airflow/utils/db.py:
##########
@@ -1282,6 +1287,7 @@ def _check_migration_errors(session: Session = NEW_SESSION) -> Iterable[str]:
check_bad_references,
)
for check_fn in check_functions:
+ log.info("running pre-migration check %s", check_fn.__name__)
Review Comment:
ok -- removed that one @ashb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a diff in pull request #23461: Log info when pre upgrade checks
Posted by GitBox <gi...@apache.org>.
dstandish commented on code in PR #23461:
URL: https://github.com/apache/airflow/pull/23461#discussion_r865143966
##########
airflow/utils/db.py:
##########
@@ -1254,6 +1257,8 @@ class BadReferenceConfig:
)
errored = True
continue
+
+ log.info("moving bad references from table %s", source_table.name)
Review Comment:
```suggestion
log.info("Moving bad references from table %s", source_table.name)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org