You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Henrik Nordstrom <he...@henriknordstrom.net> on 2008/05/15 21:44:31 UTC
Re: bugs/inappropriate coding practice discovered by
interproceduralcode analysis for version 2.2.8 of Apache
On tor, 2008-05-15 at 21:00 +0200, Ruediger Pluem wrote:
> > \apache\src\log.c(682): apr_file_puts(errstr, logf);
>
> I see nothing reasonable that we can do in this situation but ignoring the error.
syslog?
Regards
Henrik
Re: bugs/inappropriate coding practice discovered by
interproceduralcode analysis for version 2.2.8 of Apache
Posted by Henrik Nordstrom <he...@henriknordstrom.net>.
On tor, 2008-05-15 at 21:07 +0100, John ORourke wrote:
> This error would typically happen on a busy site with a full log
> partition. Writing to syslog is likely to fail for the same reason,
> and in a typical setup a full /var partition is going to cause all
> sorts of problems. Good log files are very important on busy and/or
> distributed sites, and sometimes business critical.
Many bigger servers have syslog sent over network to a central
monitoring server.
Regards
Henrik
Re: bugs/inappropriate coding practice discovered by interproceduralcode
analysis for version 2.2.8 of Apache
Posted by John ORourke <jo...@o-rourke.org>.
Henrik Nordstrom wrote:
> On tor, 2008-05-15 at 21:00 +0200, Ruediger Pluem wrote:
>
>>> \apache\src\log.c(682): apr_file_puts(errstr, logf);
>>>
>> I see nothing reasonable that we can do in this situation but ignoring the error.
>>
>
> syslog?
>
Please excuse me barging in here but I think it's appropriate to look at
typical use for this one.
This error would typically happen on a busy site with a full log
partition. Writing to syslog is likely to fail for the same reason, and
in a typical setup a full /var partition is going to cause all sorts of
problems. Good log files are very important on busy and/or distributed
sites, and sometimes business critical.
As a sysadmin I would prefer apache to die rather than end up with
corrupt logs, but I think the default should remain as it is, so perhaps
this could be a config file option? LogFaultAction or something.
cheers
John
Re: bugs/inappropriate coding practice discovered by interproceduralcode
analysis for version 2.2.8 of Apache
Posted by Ruediger Pluem <rp...@apache.org>.
On 05/15/2008 09:44 PM, Henrik Nordstrom wrote:
> On tor, 2008-05-15 at 21:00 +0200, Ruediger Pluem wrote:
>>> \apache\src\log.c(682): apr_file_puts(errstr, logf);
>> I see nothing reasonable that we can do in this situation but ignoring the error.
>
> syslog?
Syslog may not be available and is likely not configured correctly by the user in this
situation. Thus I guess the user also doesn't bother to have a look in the syslog in
this case.
Regards
RĂ¼diger