You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "karensmolermiller (GitHub)" <gi...@apache.org> on 2018/12/03 22:25:24 UTC

[GitHub] [geode] karensmolermiller opened pull request #2942: GEODE-6127 Document changes to gfsh create jndi-binding command

This PR intends to update the documentation with changes that went into the code for GEODE-5861.

@BenjaminPerryRoss Also please review, since your name is on the code commit.

[ Full content available at: https://github.com/apache/geode/pull/2942 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] karensmolermiller closed pull request #2942: GEODE-6127 Document changes to gfsh create jndi-binding command

Posted by "karensmolermiller (GitHub)" <gi...@apache.org>.

[ pull request closed by karensmolermiller ]

[ Full content available at: https://github.com/apache/geode/pull/2942 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jchen21 commented on issue #2942: GEODE-6127 Document changes to gfsh create jndi-binding command

Posted by "jchen21 (GitHub)" <gi...@apache.org>.

@dschneider-pivotal For your comment on `--conn-pooled-datasource-class`, does it apply to `XA data source connections`? I think it only works for `non-XA`.

[ Full content available at: https://github.com/apache/geode/pull/2942 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on issue #2942: GEODE-6127 Document changes to gfsh create jndi-binding command

Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.

I don't know why the create jndi-binding commands talks about XA data source connections. But this was the old description of this parameter and we did not change it. We added to it (the second sentence starting with "When used with --type=POOLED".
The strings I put in this pull request feedback come from the online gfsh help (except for the one about Hikari). You should be able to see them by running gfsh and doing help on create jndi-binding

[ Full content available at: https://github.com/apache/geode/pull/2942 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org