You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Kristofer Tomasette (Created) (JIRA)" <ji...@apache.org> on 2011/11/10 20:06:52 UTC
[jira] [Created] (HADOOP-7814) Add ability to add the contents of a
properties file to Configuration
Add ability to add the contents of a properties file to Configuration
---------------------------------------------------------------------
Key: HADOOP-7814
URL: https://issues.apache.org/jira/browse/HADOOP-7814
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 0.24.0
Reporter: Kristofer Tomasette
Priority: Minor
Fix For: 0.24.0
Add a method to Configuration that will take a location on the local filesystem of a properties file. Method should read in the file's properties and add them to the Configuration object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7814) Add ability to add the contents of
a properties file to Configuration
Posted by "Kristofer Tomasette (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164005#comment-13164005 ]
Kristofer Tomasette commented on HADOOP-7814:
---------------------------------------------
addressed findbugs
> Add ability to add the contents of a properties file to Configuration
> ---------------------------------------------------------------------
>
> Key: HADOOP-7814
> URL: https://issues.apache.org/jira/browse/HADOOP-7814
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.24.0
> Reporter: Kristofer Tomasette
> Priority: Minor
> Fix For: 0.24.0
>
> Attachments: HADOOP-7814.patch, HADOOP-7814.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Add a method to Configuration that will take a location on the local filesystem of a properties file. Method should read in the file's properties and add them to the Configuration object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7814) Add ability to add the contents of
a properties file to Configuration
Posted by "Steve Loughran (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211306#comment-13211306 ]
Steve Loughran commented on HADOOP-7814:
----------------------------------------
Thinking about this some more, my need is not just have a conf file built from a properties file, but to get more of the system environment in during the process -java home, various dirs, hostname, etc.
A way to do this -which wouldn't break anything shipping as property file support is new- would be
# load property files/resources
# support ${variable} expansion in the properties
# resolve the preloaded properties from the std XML resources & files.
# support resolution of system properties (some prefix like sysprop.)
# support resolution of env variables (some prefix like env.)
This is more ambitious, and while trivial to do in groovy (built in $var expansion with functions thrown in), needs more coding in Java;
perhaps some incremental approach is given where variable expansion is an option, and in iteration 1 it isn't allowed.
The way to do this safely is not to try an expand the Configuration class. The ultimate goal is "Create a configuration instance from one or more properties files", not "have methods in Configuration to load properties from files". Everything could be done alongside the existing class, with a new class to do the construction and configuration of a new config instance.
> Add ability to add the contents of a properties file to Configuration
> ---------------------------------------------------------------------
>
> Key: HADOOP-7814
> URL: https://issues.apache.org/jira/browse/HADOOP-7814
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Kristofer Tomasette
> Priority: Minor
> Attachments: HADOOP-7814.patch, HADOOP-7814.patch, HADOOP-7814.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Add a method to Configuration that will take a location on the local filesystem of a properties file. Method should read in the file's properties and add them to the Configuration object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7814) Add ability to add the contents of
a properties file to Configuration
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164036#comment-13164036 ]
Hadoop QA commented on HADOOP-7814:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12506363/HADOOP-7814.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 9 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/439//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/439//console
This message is automatically generated.
> Add ability to add the contents of a properties file to Configuration
> ---------------------------------------------------------------------
>
> Key: HADOOP-7814
> URL: https://issues.apache.org/jira/browse/HADOOP-7814
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.24.0
> Reporter: Kristofer Tomasette
> Priority: Minor
> Fix For: 0.24.0
>
> Attachments: HADOOP-7814.patch, HADOOP-7814.patch, HADOOP-7814.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Add a method to Configuration that will take a location on the local filesystem of a properties file. Method should read in the file's properties and add them to the Configuration object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7814) Add ability to add the contents of a
properties file to Configuration
Posted by "Kristofer Tomasette (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristofer Tomasette updated HADOOP-7814:
----------------------------------------
Attachment: HADOOP-7814.patch
> Add ability to add the contents of a properties file to Configuration
> ---------------------------------------------------------------------
>
> Key: HADOOP-7814
> URL: https://issues.apache.org/jira/browse/HADOOP-7814
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.24.0
> Reporter: Kristofer Tomasette
> Priority: Minor
> Fix For: 0.24.0
>
> Attachments: HADOOP-7814.patch, HADOOP-7814.patch, HADOOP-7814.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Add a method to Configuration that will take a location on the local filesystem of a properties file. Method should read in the file's properties and add them to the Configuration object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7814) Add ability to add the contents of
a properties file to Configuration
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162981#comment-13162981 ]
Hadoop QA commented on HADOOP-7814:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12506146/HADOOP-7814.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 9 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.http.TestHttpServer
org.apache.hadoop.security.token.delegation.TestDelegationToken
org.apache.hadoop.ipc.TestRPC
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/434//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/434//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/434//console
This message is automatically generated.
> Add ability to add the contents of a properties file to Configuration
> ---------------------------------------------------------------------
>
> Key: HADOOP-7814
> URL: https://issues.apache.org/jira/browse/HADOOP-7814
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.24.0
> Reporter: Kristofer Tomasette
> Priority: Minor
> Fix For: 0.24.0
>
> Attachments: HADOOP-7814.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Add a method to Configuration that will take a location on the local filesystem of a properties file. Method should read in the file's properties and add them to the Configuration object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7814) Add ability to add the contents of a
properties file to Configuration
Posted by "Kristofer Tomasette (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristofer Tomasette updated HADOOP-7814:
----------------------------------------
Attachment: HADOOP-7814.patch
> Add ability to add the contents of a properties file to Configuration
> ---------------------------------------------------------------------
>
> Key: HADOOP-7814
> URL: https://issues.apache.org/jira/browse/HADOOP-7814
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.24.0
> Reporter: Kristofer Tomasette
> Priority: Minor
> Fix For: 0.24.0
>
> Attachments: HADOOP-7814.patch, HADOOP-7814.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Add a method to Configuration that will take a location on the local filesystem of a properties file. Method should read in the file's properties and add them to the Configuration object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7814) Add ability to add the contents of a
properties file to Configuration
Posted by "Kristofer Tomasette (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristofer Tomasette updated HADOOP-7814:
----------------------------------------
Attachment: HADOOP-7814.patch
> Add ability to add the contents of a properties file to Configuration
> ---------------------------------------------------------------------
>
> Key: HADOOP-7814
> URL: https://issues.apache.org/jira/browse/HADOOP-7814
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.24.0
> Reporter: Kristofer Tomasette
> Priority: Minor
> Fix For: 0.24.0
>
> Attachments: HADOOP-7814.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Add a method to Configuration that will take a location on the local filesystem of a properties file. Method should read in the file's properties and add them to the Configuration object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7814) Add ability to add the contents of
a properties file to Configuration
Posted by "Kristofer Tomasette (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211115#comment-13211115 ]
Kristofer Tomasette commented on HADOOP-7814:
---------------------------------------------
Thanks for the feedback. Will address the points u made this week.
> Add ability to add the contents of a properties file to Configuration
> ---------------------------------------------------------------------
>
> Key: HADOOP-7814
> URL: https://issues.apache.org/jira/browse/HADOOP-7814
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Kristofer Tomasette
> Priority: Minor
> Attachments: HADOOP-7814.patch, HADOOP-7814.patch, HADOOP-7814.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Add a method to Configuration that will take a location on the local filesystem of a properties file. Method should read in the file's properties and add them to the Configuration object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7814) Add ability to add the contents of a
properties file to Configuration
Posted by "Kristofer Tomasette (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristofer Tomasette updated HADOOP-7814:
----------------------------------------
Status: Patch Available (was: Open)
> Add ability to add the contents of a properties file to Configuration
> ---------------------------------------------------------------------
>
> Key: HADOOP-7814
> URL: https://issues.apache.org/jira/browse/HADOOP-7814
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.24.0
> Reporter: Kristofer Tomasette
> Priority: Minor
> Fix For: 0.24.0
>
> Attachments: HADOOP-7814.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Add a method to Configuration that will take a location on the local filesystem of a properties file. Method should read in the file's properties and add them to the Configuration object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7814) Add ability to add the contents of
a properties file to Configuration
Posted by "Steve Loughran (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211075#comment-13211075 ]
Steve Loughran commented on HADOOP-7814:
----------------------------------------
basic idea looks good, and I can see some uses,
# I propose adding put this into the 0.23.x branch/trunk rather than the stable 1.x branch
# An export to properties could be good too for the full round tripping (and some useful diagnostics on bug reports)
Though there are some coding style and practises to review before a patch could be applied:
{{Configuration}}
* major re-ordering of imports
* spacing doesn't follow style rutes
* exception logging events should always include the exception as the second
argument so that the stack trace is preserved
* the {{in.close()}} handler in the {{finally}} clause should just log at info and not at fatal
{{TestConfiguration}}
* there's an import * import static org.junit.Assert.*;
* re-ordering of imports
* some gratutious indentation
> Add ability to add the contents of a properties file to Configuration
> ---------------------------------------------------------------------
>
> Key: HADOOP-7814
> URL: https://issues.apache.org/jira/browse/HADOOP-7814
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Kristofer Tomasette
> Priority: Minor
> Attachments: HADOOP-7814.patch, HADOOP-7814.patch, HADOOP-7814.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Add a method to Configuration that will take a location on the local filesystem of a properties file. Method should read in the file's properties and add them to the Configuration object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7814) Add ability to add the contents of
a properties file to Configuration
Posted by "Kristofer Tomasette (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164037#comment-13164037 ]
Kristofer Tomasette commented on HADOOP-7814:
---------------------------------------------
I believe the "-1 javadoc" is not related to this patch.
> Add ability to add the contents of a properties file to Configuration
> ---------------------------------------------------------------------
>
> Key: HADOOP-7814
> URL: https://issues.apache.org/jira/browse/HADOOP-7814
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.24.0
> Reporter: Kristofer Tomasette
> Priority: Minor
> Fix For: 0.24.0
>
> Attachments: HADOOP-7814.patch, HADOOP-7814.patch, HADOOP-7814.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Add a method to Configuration that will take a location on the local filesystem of a properties file. Method should read in the file's properties and add them to the Configuration object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7814) Add ability to add the contents of a
properties file to Configuration
Posted by "Kristofer Tomasette (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristofer Tomasette updated HADOOP-7814:
----------------------------------------
Affects Version/s: (was: 0.24.0)
1.0.0
Fix Version/s: (was: 0.24.0)
> Add ability to add the contents of a properties file to Configuration
> ---------------------------------------------------------------------
>
> Key: HADOOP-7814
> URL: https://issues.apache.org/jira/browse/HADOOP-7814
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Kristofer Tomasette
> Priority: Minor
> Attachments: HADOOP-7814.patch, HADOOP-7814.patch, HADOOP-7814.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Add a method to Configuration that will take a location on the local filesystem of a properties file. Method should read in the file's properties and add them to the Configuration object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7814) Add ability to add the contents of
a properties file to Configuration
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164021#comment-13164021 ]
Hadoop QA commented on HADOOP-7814:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12506342/HADOOP-7814.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 9 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/438//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/438//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/438//console
This message is automatically generated.
> Add ability to add the contents of a properties file to Configuration
> ---------------------------------------------------------------------
>
> Key: HADOOP-7814
> URL: https://issues.apache.org/jira/browse/HADOOP-7814
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.24.0
> Reporter: Kristofer Tomasette
> Priority: Minor
> Fix For: 0.24.0
>
> Attachments: HADOOP-7814.patch, HADOOP-7814.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Add a method to Configuration that will take a location on the local filesystem of a properties file. Method should read in the file's properties and add them to the Configuration object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7814) Add ability to add the contents of
a properties file to Configuration
Posted by "Kristofer Tomasette (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147945#comment-13147945 ]
Kristofer Tomasette commented on HADOOP-7814:
---------------------------------------------
Patch is forthcoming.
> Add ability to add the contents of a properties file to Configuration
> ---------------------------------------------------------------------
>
> Key: HADOOP-7814
> URL: https://issues.apache.org/jira/browse/HADOOP-7814
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 0.24.0
> Reporter: Kristofer Tomasette
> Priority: Minor
> Fix For: 0.24.0
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Add a method to Configuration that will take a location on the local filesystem of a properties file. Method should read in the file's properties and add them to the Configuration object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira