You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/17 23:30:02 UTC

[GitHub] marcoabreu commented on issue #12237: [MXNET-696] Delete comment line that contains a Unicode character

marcoabreu commented on issue #12237: [MXNET-696] Delete comment line that contains a Unicode character
URL: https://github.com/apache/incubator-mxnet/pull/12237#issuecomment-414012008
 
 
   Thank you and sorry for the revert. Please feel free to re-add the functionality you added. We just reverted the PR to ensure we are back in a state that we know is working properly. We also made some changes around python 2 and 3 and thus we wanted to rule out any errors related to these switches.
   
   It seems strange that it is necessary to remove that comment. Do you think you would be able to add a check to our linter that would detect cases like this before we encounter them during runtime? That would be SUPER helpful :)
   
   In general, thanks a lot for improving the usability of mxnet! It is very appreciated.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services