[jira] [Comment Edited] (FLINK-10297) PostVersionedIOReadableWritable ignores result of InputStream.read(...)

["Stefan Richter (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606844#comment-16606844 ] 

Stefan Richter edited comment on FLINK-10297 at 9/7/18 8:35 AM:
----------------------------------------------------------------

Yes, that is a very common trap that can have very bad consequences. It is problematic that this even exists with such a similar name. I suggest that we use this opportunity for a find usage to see if this was not also done in other places again. I also suggest to activate the findbugs warning for this in the IDE.


was (Author: srichter):
Yes, that is a very common trap that can have very bad consequences. It is problematic that this even exists with such a similar name. I suggest that we use this opportunity for a find usage to see if this was not also done in other places again.

> PostVersionedIOReadableWritable ignores result of InputStream.read(...)
> -----------------------------------------------------------------------
>
>                 Key: FLINK-10297
>                 URL: https://issues.apache.org/jira/browse/FLINK-10297
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.4.2, 1.5.3, 1.6.0
>            Reporter: Stefan Richter
>            Priority: Critical
>
> PostVersionedIOReadableWritable ignores result of {{InputStream.read(...)}}. Probably the intention was to invoke {{readFully}}. As it is now, this can lead to a corrupted deserialization.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)