[jira] [Created] (SENTRY-1471) TestHDFSIntegrationBase.java implements HDFS ACL checking incorrectly

["Vadim Spector (JIRA)" <ji...@apache.org>]

Vadim Spector created SENTRY-1471:
-------------------------------------

             Summary: TestHDFSIntegrationBase.java implements HDFS ACL checking incorrectly
                 Key: SENTRY-1471
                 URL: https://issues.apache.org/jira/browse/SENTRY-1471
             Project: Sentry
          Issue Type: Bug
          Components: Sentry
            Reporter: Vadim Spector
            Assignee: Anne Yu


verifyOnAllSubDirsHelper() in TestHDFSIntegrationBase.java has a bug. When the number of retries exceeds max value (the "else" portion of "if (retry > 0)" statement, it erroneously assigns hasSucceeded = true. It means that verifyOnAllSubDirsHelper() never returns false.

Once the problem was fixed in a local development branch, several tests in TestHDFSIntegrationAdvanced.java started failing. TestHDFSIntegrationEnd2End tests are still ok.

Also, it is unfortunate that TestHDFSIntegrationBase() returns boolean instead of throwing the original AssertionError which contains information about expected vs. found ACL permissions - this information is invaluable for debugging. The fix is easy - the to-be-fixed "else" portion is inside the "catch (Throwable th)" clause, so it should just re-throw caught exception. This makes "hasSucceeded" variable unnecessary - verifyOnAllSubDirsHelper() should have "void" return type.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)