You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/11 04:08:29 UTC
[GitHub] [incubator-tvm] tqchen opened a new pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings
tqchen opened a new pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450
This PR fixes various warnings bought by MSVC.
TODO: deprecate `__tvm_main__` symbol and update
testcase so windows works as normal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tmoreau89 commented on pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450#issuecomment-691292496
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450#issuecomment-690861794
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tmoreau89 merged pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings
Posted by GitBox <gi...@apache.org>.
tmoreau89 merged pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450#issuecomment-690861794
cc @tmoreau89 @rkimball
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450#issuecomment-690861794
cc @tmoreau89 @rkimball @jroesch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tmoreau89 merged pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings
Posted by GitBox <gi...@apache.org>.
tmoreau89 merged pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450#discussion_r486809195
##########
File path: CMakeLists.txt
##########
@@ -109,6 +109,22 @@ if(MSVC)
endif(${flag_var} MATCHES "/MD")
endforeach(flag_var)
endif()
+ # Disable common MSVC warnings
+ # Integer conversion warnings(e.g. int64 to int)
+ add_compile_options(/wd4244)
Review comment:
we might revisit to cmake file to avoid global flags, but for now it is good enough
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450#issuecomment-690909842
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450#issuecomment-690909842
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450#issuecomment-690861794
cc @tmoreau89 @rkimball @jroesch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450#discussion_r486809195
##########
File path: CMakeLists.txt
##########
@@ -109,6 +109,22 @@ if(MSVC)
endif(${flag_var} MATCHES "/MD")
endforeach(flag_var)
endif()
+ # Disable common MSVC warnings
+ # Integer conversion warnings(e.g. int64 to int)
+ add_compile_options(/wd4244)
Review comment:
we might revisit to cmake file to avoid global flags, but for now it is good enough
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450#issuecomment-690909842
It looks very clean now!
I actually found the unicode in data_layout.h: they are in line 317 and 318, which is "…"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450#discussion_r486809195
##########
File path: CMakeLists.txt
##########
@@ -109,6 +109,22 @@ if(MSVC)
endif(${flag_var} MATCHES "/MD")
endforeach(flag_var)
endif()
+ # Disable common MSVC warnings
+ # Integer conversion warnings(e.g. int64 to int)
+ add_compile_options(/wd4244)
Review comment:
we might revisit to cmake file to avoid global flags, but for now it is good enough
##########
File path: CMakeLists.txt
##########
@@ -109,6 +109,22 @@ if(MSVC)
endif(${flag_var} MATCHES "/MD")
endforeach(flag_var)
endif()
+ # Disable common MSVC warnings
+ # Integer conversion warnings(e.g. int64 to int)
+ add_compile_options(/wd4244)
Review comment:
we might revisit to cmake file to avoid global flags, but for now it is good enough
##########
File path: CMakeLists.txt
##########
@@ -109,6 +109,22 @@ if(MSVC)
endif(${flag_var} MATCHES "/MD")
endforeach(flag_var)
endif()
+ # Disable common MSVC warnings
+ # Integer conversion warnings(e.g. int64 to int)
+ add_compile_options(/wd4244)
Review comment:
we might revisit to cmake file to avoid global flags, but for now it is good enough
##########
File path: CMakeLists.txt
##########
@@ -109,6 +109,22 @@ if(MSVC)
endif(${flag_var} MATCHES "/MD")
endforeach(flag_var)
endif()
+ # Disable common MSVC warnings
+ # Integer conversion warnings(e.g. int64 to int)
+ add_compile_options(/wd4244)
Review comment:
we might revisit to cmake file to avoid global flags, but for now it is good enough
##########
File path: CMakeLists.txt
##########
@@ -109,6 +109,22 @@ if(MSVC)
endif(${flag_var} MATCHES "/MD")
endforeach(flag_var)
endif()
+ # Disable common MSVC warnings
+ # Integer conversion warnings(e.g. int64 to int)
+ add_compile_options(/wd4244)
Review comment:
we might revisit to cmake file to avoid global flags, but for now it is good enough
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tmoreau89 merged pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings
Posted by GitBox <gi...@apache.org>.
tmoreau89 merged pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tmoreau89 commented on pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450#issuecomment-691292496
Thank you @junrushao1994 @ZihengJiang @tqchen , the PR has been merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450#issuecomment-690861794
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450#issuecomment-690861794
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450#discussion_r486809195
##########
File path: CMakeLists.txt
##########
@@ -109,6 +109,22 @@ if(MSVC)
endif(${flag_var} MATCHES "/MD")
endforeach(flag_var)
endif()
+ # Disable common MSVC warnings
+ # Integer conversion warnings(e.g. int64 to int)
+ add_compile_options(/wd4244)
Review comment:
we might revisit to cmake file to avoid global flags, but for now it is good enough
##########
File path: CMakeLists.txt
##########
@@ -109,6 +109,22 @@ if(MSVC)
endif(${flag_var} MATCHES "/MD")
endforeach(flag_var)
endif()
+ # Disable common MSVC warnings
+ # Integer conversion warnings(e.g. int64 to int)
+ add_compile_options(/wd4244)
Review comment:
we might revisit to cmake file to avoid global flags, but for now it is good enough
##########
File path: CMakeLists.txt
##########
@@ -109,6 +109,22 @@ if(MSVC)
endif(${flag_var} MATCHES "/MD")
endforeach(flag_var)
endif()
+ # Disable common MSVC warnings
+ # Integer conversion warnings(e.g. int64 to int)
+ add_compile_options(/wd4244)
Review comment:
we might revisit to cmake file to avoid global flags, but for now it is good enough
##########
File path: CMakeLists.txt
##########
@@ -109,6 +109,22 @@ if(MSVC)
endif(${flag_var} MATCHES "/MD")
endforeach(flag_var)
endif()
+ # Disable common MSVC warnings
+ # Integer conversion warnings(e.g. int64 to int)
+ add_compile_options(/wd4244)
Review comment:
we might revisit to cmake file to avoid global flags, but for now it is good enough
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tmoreau89 commented on pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450#issuecomment-691292496
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450#issuecomment-690861794
cc @tmoreau89 @rkimball
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org