[GitHub] [activemq-artemis] gemmellr commented on a change in pull request #3320: ARTEMIS-2937 Documentation improvements

[GitBox <gi...@apache.org>]

gemmellr commented on a change in pull request #3320:
URL: https://github.com/apache/activemq-artemis/pull/3320#discussion_r514463051



##########
File path: docs/user-manual/en/amqp-broker-connections.md
##########
@@ -71,9 +71,9 @@ Using address expressions:
 ```xml
 <broker-connections>
     <amqp-connection uri="tcp://MY_HOST:MY_PORT" name="my-broker">
-        <sender match="queues.#"/>
+        <sender addres-match="queues.#"/>

Review comment:
       Typo in addres**s**

##########
File path: artemis-tools/src/test/resources/artemis-configuration.xsd
##########
@@ -3865,20 +3863,12 @@
                </xsd:annotation>
             </xsd:element>
 
-            <xsd:element name="page-store-name" type="xsd:string" maxOccurs="1" minOccurs="0">
-               <xsd:annotation>
-                  <xsd:documentation>
-                     the name of the page store to use, to allow the page store to coalesce for address hierarchies when wildcard routing is in play
-                  </xsd:documentation>
-               </xsd:annotation>
-            </xsd:element>
-
          </xsd:all>
 
          <xsd:attribute name="match" type="xsd:string" use="required">
             <xsd:annotation>
                <xsd:documentation>
-                  pattern for matching settings against addresses; can use wildcards
+                  pattern for matching settings against addresses; can use wildards

Review comment:
       Introduces a typo in "wildcards".

##########
File path: examples/features/broker-connection/amqp-sending-overssl/src/main/resources/activemq/server0/broker.xml
##########
@@ -37,7 +37,7 @@ under the License.
 
       <broker-connections>
          <amqp-connection uri="tcp://localhost:5772?sslEnabled=true;trustStorePath=activemq.example.truststore;trustStorePassword=activemqexample" name="otherSSL" retry-interval="1000">
-            <sender match="#"/>
+            <sender address-match="#"/>

Review comment:
       #3321 may conflict here, can you please jsut update it and merge, ill be heading off now.

##########
File path: docs/user-manual/en/amqp-broker-connections.md
##########
@@ -71,9 +71,9 @@ Using address expressions:
 ```xml
 <broker-connections>
     <amqp-connection uri="tcp://MY_HOST:MY_PORT" name="my-broker">
-        <sender match="queues.#"/>
+        <sender addres-match="queues.#"/>
         <!-- notice the local queues for remotequeues.# need to be created on this broker -->
-        <receiver match="remotequeues.#"/>
+        <receiver addres-match="remotequeues.#"/>

Review comment:
       Typo in addres**s**

##########
File path: docs/user-manual/en/amqp-broker-connections.md
##########
@@ -130,7 +128,7 @@ With a peer configuration, you have the same properties that you have on a sende
 ```xml
 <broker-connections>
     <amqp-connection uri="tcp://MY_HOST:MY_PORT" name="my-router">
-       <peer match="queues.#"/>
+       <peer addres-match="queues.#"/>

Review comment:
       Typo in addres**s**

##########
File path: docs/user-manual/en/amqp-broker-connections.md
##########
@@ -163,7 +161,29 @@ For more information refer to the "brokered messaging" documentation for [Apache
 
 *Important:* You do not need to configure the router with a connector or auto-links to communicate with the broker. The brokers peer configuration replaces these aspects of the router waypoint usage.
 
-# Mirror 
+## Address Consideration
+It is highly recommended that you keep `address name` and `queue name` the same, as when you use a queue with its distinct name (as in the following example), senders and receivers will always use the `address name` when creating the remote endpoint.
+
+```xml
+<broker-connections>
+    <amqp-connection uri="tcp://MY_HOST:MY_PORT" name="my-broker">
+       <sender address-match="queues.#"/>
+    </amqp-connection>
+</broker-connections>
+<addresses>
+     <address name="queues.A">
+        <anycast>
+           <queue name="distinctNameQueue.A"/>
+        </anycast>
+     </address>
+</addresses>
+```
+
+In the above example the `broker connection` would create an AMQP sender towards "queues.A". 

Review comment:
       For clarity I would use "addressprefix.#" and  "addressprefix.A"or some such alterantive. Its just simpler to consider when not having "queues" in the address value when thinking of it as an address name.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org