You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "nikita15p (via GitHub)" <gi...@apache.org> on 2024/04/01 03:44:11 UTC
[PR] OMID-289 Fix missing assertions for TestOmidClientConfiguration.java [phoenix-omid]
nikita15p opened a new pull request, #160:
URL: https://github.com/apache/phoenix-omid/pull/160
Added missing assertions and replaced assertNotNull with accurate assert equals statement for TestOmidClientConfiguration
validated the new additions in the file by executing these test cases. All are passing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OMID-289 Add additional asserts in TestOmidClientConfiguration.java [phoenix-omid]
Posted by "nikita15p (via GitHub)" <gi...@apache.org>.
nikita15p commented on PR #160:
URL: https://github.com/apache/phoenix-omid/pull/160#issuecomment-2031731827
@stoty thanks for the review. I have made changes as per the review comments, please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OMID-289 Fix missing assertions for TestOmidClientConfiguration.java [phoenix-omid]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #160:
URL: https://github.com/apache/phoenix-omid/pull/160#issuecomment-2031124386
The change looks good.
I'd prefer to rename the ticket and commit to something like
"Add additional asserts in TestOmid..."
You can always add more checks in a test, so this is more of an improvement than a fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OMID-289 Add additional asserts in TestOmidClientConfiguration.java [phoenix-omid]
Posted by "chrajeshbabu (via GitHub)" <gi...@apache.org>.
chrajeshbabu merged PR #160:
URL: https://github.com/apache/phoenix-omid/pull/160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org