You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@s2graph.apache.org by "DOYUNG YOON (JIRA)" <ji...@apache.org> on 2018/03/22 12:21:00 UTC

[jira] [Created] (S2GRAPH-187) Make `toQuery` use `toVertex` to parse vertex from query JSON on RequestParser

DOYUNG YOON created S2GRAPH-187:
-----------------------------------

             Summary: Make `toQuery` use `toVertex` to parse vertex from query JSON on RequestParser
                 Key: S2GRAPH-187
                 URL: https://issues.apache.org/jira/browse/S2GRAPH-187
             Project: S2Graph
          Issue Type: Improvement
            Reporter: DOYUNG YOON
            Assignee: DOYUNG YOON


There is code duplication on `toQuery` and `toVertex` at `RequestParser`.

Both of two methods need to read JSON value and extract vertex. 
The only difference between two is `toQuery` only need vertexId, not props, timestamp, operation, but `toVertex` need others.

Different implementation increase probability for bugs like S2GRAPH-186, so I suggest refactoring theses.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)