You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/24 19:22:46 UTC

[GitHub] [incubator-superset] nytai commented on a change in pull request #9015: [dashboard] fix, enable info endpoint

nytai commented on a change in pull request #9015: [dashboard] fix, enable info endpoint
URL: https://github.com/apache/incubator-superset/pull/9015#discussion_r370801498
 
 

 ##########
 File path: superset/constants.py
 ##########
 @@ -58,4 +59,4 @@ class RouteMethod:  # pylint: disable=too-few-public-methods
     # Commonly used sets
     CRUD_SET = {ADD, LIST, EDIT, DELETE, ACTION_POST}
     RELATED_VIEW_SET = {ADD, LIST, EDIT, DELETE}
-    REST_MODEL_VIEW_CRUD_SET = {DELETE, GET, GET_LIST, POST, PUT}
+    REST_MODEL_VIEW_CRUD_SET = {DELETE, GET, GET_LIST, POST, PUT, INFO}
 
 Review comment:
   We can remove it from the default and enable the info endpoint on a per-case basis. That was the original approach: https://github.com/apache/incubator-superset/pull/9015/commits/a5488e2aad8cc7b0daa95bc9382697dcc07a51b5
   but it seems like we'll need to info endpoint in most cases 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org