You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/12/14 06:41:11 UTC
[GitHub] [dolphinscheduler] roylion opened a new issue #7396: [Bug] [TenantService.updateTenant()]
roylion opened a new issue #7396:
URL: https://github.com/apache/dolphinscheduler/issues/7396
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
/**
* if the tenant code is modified, the original resource needs to be copied to the new tenant.
*/
if (!tenant.getTenantCode().equals(tenantCode)) {
if (checkTenantExists(tenantCode)) { **********************此处判断条件有误**********************
// if hdfs startup
省略。。。
} else {
putMsg(result, Status.OS_TENANT_CODE_HAS_ALREADY_EXISTS);
return result;
}
}
### What you expected to happen
/**
* if the tenant code is modified, the original resource needs to be copied to the new tenant.
*/
if (!tenant.getTenantCode().equals(tenantCode)) {
if (!checkTenantExists(tenantCode)) { **********************此处判断条件改为不存在时复制资源**********************
// if hdfs startup
省略。。。
} else {
putMsg(result, Status.OS_TENANT_CODE_HAS_ALREADY_EXISTS);
return result;
}
}
### How to reproduce
修改一个已存在的租户名称，且新的租户名称没有与其他租户名称重复，提交时会提示 “操作系统租户已存在”
版本号：2.0.1-release
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] lenboo commented on issue #7396: [Bug] [API]Update tenant failed in API
Posted by GitBox <gi...@apache.org>.
lenboo commented on issue #7396:
URL: https://github.com/apache/dolphinscheduler/issues/7396#issuecomment-1005348755
> Could you shed some more light on it? Give more details about this issue.
>
> Seems like you can't modify the tenant's name: <img alt="image" width="1079" src="https://user-images.githubusercontent.com/4928204/145965344-37f8131e-8e27-4eba-87b2-0cf2ac90acb7.png">
Maybe we should remove the update interface in api.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #7396: [Bug] [API]Update tenant failed in API
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #7396:
URL: https://github.com/apache/dolphinscheduler/issues/7396#issuecomment-1036824018
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed issue #7396: [Bug] [API]Update tenant failed in API
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #7396:
URL: https://github.com/apache/dolphinscheduler/issues/7396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] calvinjiang commented on issue #7396: [Bug] [TenantService.updateTenant()]
Posted by GitBox <gi...@apache.org>.
calvinjiang commented on issue #7396:
URL: https://github.com/apache/dolphinscheduler/issues/7396#issuecomment-993315484
Could you shed some more light on it? Give more details about this issue.
Seems like you can't modify the tenant's name:
<img width="1079" alt="image" src="https://user-images.githubusercontent.com/4928204/145965344-37f8131e-8e27-4eba-87b2-0cf2ac90acb7.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #7396: [Bug] [API]Update tenant failed in API
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #7396:
URL: https://github.com/apache/dolphinscheduler/issues/7396#issuecomment-1030450933
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #7396: [Bug] [TenantService.updateTenant()]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #7396:
URL: https://github.com/apache/dolphinscheduler/issues/7396#issuecomment-993207840
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
/**
* if the tenant code is modified, the original resource needs to be copied to the new tenant.
*/
if (!tenant.getTenantCode().equals(tenantCode)) {
if (checkTenantExists(tenantCode)) { **********************此处判断条件有误**********************
// if hdfs startup
省略。。。
} else {
putMsg(result, Status.OS_TENANT_CODE_HAS_ALREADY_EXISTS);
return result;
}
}
### What you expected to happen
/**
* if the tenant code is modified, the original resource needs to be copied to the new tenant.
*/
if (!tenant.getTenantCode().equals(tenantCode)) {
if (!checkTenantExists(tenantCode)) { **********************此处判断条件改为不存在时复制资源**********************
// if hdfs startup
省略。。。
} else {
putMsg(result, Status.OS_TENANT_CODE_HAS_ALREADY_EXISTS);
return result;
}
}
### How to reproduce
修改一个已存在的租户名称，且新的租户名称没有与其他租户名称重复，提交时会提示 “操作系统租户已存在”
版本号：2.0.1-release
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] calvinjiang commented on issue #7396: [Bug] [TenantService.updateTenant()]
Posted by GitBox <gi...@apache.org>.
calvinjiang commented on issue #7396:
URL: https://github.com/apache/dolphinscheduler/issues/7396#issuecomment-993268767
I will check this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #7396: [Bug] [TenantService.updateTenant()]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #7396:
URL: https://github.com/apache/dolphinscheduler/issues/7396#issuecomment-993207984
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org