[GitHub] [iceberg] rdblue commented on pull request #4011: Allow table defaults to be configured and/ or enforced at catalog level using catalog properties.

[GitBox <gi...@apache.org>]

rdblue commented on pull request #4011:
URL: https://github.com/apache/iceberg/pull/4011#issuecomment-1025260143


   I took a quick look. I think the idea is reasonable, but the implementation needs to be changed:
   * I think `table-default` and `table-override` are better property prefixes
   * This should not modify the `Catalog` interface or `CachingCatalog`
   * The best place to add this is in `BaseMetastoreCatalog` or other catalogs you need to update
   * Subclasses should pass properties using `super(...)` in the constructor, not set parent fields
   * Please reduce the footprint of this change by not modifying classes unnecessarily; add defaults to avoid touching so many files


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org