You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/03/08 15:48:06 UTC
[kudu-CR] [docs] update build instructions to run on SLES 15
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17160
Change subject: [docs] update build instructions to run on SLES 15
......................................................................
[docs] update build instructions to run on SLES 15
CC_FOR_BUILD, CPP_FOR_BUILD, CXXCPP_FOR_BUILD are necessary to build
protobuf. An alternative approach would be patching the build script
to provide those if building on SLES.
Change-Id: I126d9d70288931ace6f6534c3b4f768b7dee17b1
---
M docs/installation.adoc
1 file changed, 25 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/17160/1
--
To view, visit http://gerrit.cloudera.org:8080/17160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I126d9d70288931ace6f6534c3b4f768b7dee17b1
Gerrit-Change-Number: 17160
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [docs] update build instructions to run on SLES 15
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17160 )
Change subject: [docs] update build instructions to run on SLES 15
......................................................................
[docs] update build instructions to run on SLES 15
CC_FOR_BUILD, CPP_FOR_BUILD, CXXCPP_FOR_BUILD are necessary to build
protobuf on SLES with gcc-8/g++-8. An alternative approach would be
patching the build script to provide those if building on SLES.
Change-Id: I126d9d70288931ace6f6534c3b4f768b7dee17b1
Reviewed-on: http://gerrit.cloudera.org:8080/17160
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M build-support/enable_devtoolset.sh
M docs/installation.adoc
2 files changed, 19 insertions(+), 11 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I126d9d70288931ace6f6534c3b4f768b7dee17b1
Gerrit-Change-Number: 17160
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] update build instructions to run on SLES 15
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17160 )
Change subject: [docs] update build instructions to run on SLES 15
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/17160/1/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/17160/1/docs/installation.adoc@413
PS1, Line 413: $ CC=gcc-8 CXX=g++-8 ctest -R "client_examples-test*"
> Won't `build-support/enable_devtoolset.sh` handle this?
I guess it helps if running tests in the same shell session or a descendant one. Probably, that's what expected :) Well, let's assume so.
Done.
http://gerrit.cloudera.org:8080/#/c/17160/1/docs/installation.adoc@522
PS1, Line 522: java-11-openjdk-devel
> Is it still possible to use Java 8 for sles 15? All of our other builds sti
It is: Java 8 is in legacy module, but it's available. Done.
http://gerrit.cloudera.org:8080/#/c/17160/1/docs/installation.adoc@525
PS1, Line 525: export CC_FOR_BUILD=gcc-8
> Can we add this to build-support/enable_devtoolset.sh if it's needed?
Yep, that looks like a good option.
Those xxx_FOR_BUILD variables are specific to protobuf, all other components are able to find those based on CC/CXX settings. Probably, the better way is patching protobuf config scripts to do proper thing. I'll add this into the script and add corresponding TODO along.
--
To view, visit http://gerrit.cloudera.org:8080/17160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I126d9d70288931ace6f6534c3b4f768b7dee17b1
Gerrit-Change-Number: 17160
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 08 Mar 2021 19:45:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] update build instructions to run on SLES 15
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17160 )
Change subject: [docs] update build instructions to run on SLES 15
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/17160/1/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/17160/1/docs/installation.adoc@413
PS1, Line 413: $ CC=gcc-8 CXX=g++-8 ctest -R "client_examples-test*"
Won't `build-support/enable_devtoolset.sh` handle this?
http://gerrit.cloudera.org:8080/#/c/17160/1/docs/installation.adoc@522
PS1, Line 522: java-11-openjdk-devel
Is it still possible to use Java 8 for sles 15? All of our other builds still use Java 8.
http://gerrit.cloudera.org:8080/#/c/17160/1/docs/installation.adoc@525
PS1, Line 525: export CC_FOR_BUILD=gcc-8
Can we add this to build-support/enable_devtoolset.sh if it's needed?
--
To view, visit http://gerrit.cloudera.org:8080/17160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I126d9d70288931ace6f6534c3b4f768b7dee17b1
Gerrit-Change-Number: 17160
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 08 Mar 2021 15:59:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] update build instructions to run on SLES 15
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17160
to look at the new patch set (#2).
Change subject: [docs] update build instructions to run on SLES 15
......................................................................
[docs] update build instructions to run on SLES 15
CC_FOR_BUILD, CPP_FOR_BUILD, CXXCPP_FOR_BUILD are necessary to build
protobuf on SLES with gcc-8/g++-8. An alternative approach would be
patching the build script to provide those if building on SLES.
Change-Id: I126d9d70288931ace6f6534c3b4f768b7dee17b1
---
M build-support/enable_devtoolset.sh
M docs/installation.adoc
2 files changed, 19 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/17160/2
--
To view, visit http://gerrit.cloudera.org:8080/17160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I126d9d70288931ace6f6534c3b4f768b7dee17b1
Gerrit-Change-Number: 17160
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] update build instructions to run on SLES 15
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17160 )
Change subject: [docs] update build instructions to run on SLES 15
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I126d9d70288931ace6f6534c3b4f768b7dee17b1
Gerrit-Change-Number: 17160
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 22 Mar 2021 17:21:20 +0000
Gerrit-HasComments: No