[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4394: improve hashjoin execution metrics

[GitBox <gi...@apache.org>]

alamb commented on code in PR #4394:
URL: https://github.com/apache/arrow-datafusion/pull/4394#discussion_r1033989776


##########
datafusion/core/src/physical_plan/joins/hash_join.rs:
##########
@@ -1551,11 +1557,13 @@ impl HashJoinStream {
                             | JoinType::RightAnti => {}
                         }
                     }
-                    Some(result.map(|x| x.0))
+                    let final_result = Some(result.map(|x| x.0));
+                    timer.done();

Review Comment:
   I think drop will handle this for you (so the explicit `done()` is not needed)



##########
datafusion/core/src/physical_plan/joins/hash_join.rs:
##########
@@ -1487,10 +1492,12 @@ impl HashJoinStream {
         &mut self,
         cx: &mut std::task::Context<'_>,
     ) -> Poll<Option<ArrowResult<RecordBatch>>> {
+        let build_timer = self.join_metrics.build_time.timer();

Review Comment:
   This will be timing the overall clock time (not the cpu time) of the build. As long as that is what you are trying to time 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org