You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/09/13 03:19:21 UTC

[GitHub] [incubator-kvrocks] git-hulk commented on pull request #870: Replace bench with test

git-hulk commented on PR #870:
URL: https://github.com/apache/incubator-kvrocks/pull/870#issuecomment-1244844809

   https://github.com/apache/incubator-kvrocks/blob/unstable/tests/cppunit/rwlock_test.cc#L170
   
   This unit test sleep time is NOT right, expected 100ms but current is 1ms. I think 1ms is too short to guarantee the else condition thread will be always be scheduled before the if condition. I'll bring this sleep time fix in the next PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org