You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2004/09/01 19:44:04 UTC
[jira] Created: (MPRAR-1) plugin properties are not used correctly
Message:
A new issue has been created in JIRA.
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPRAR-1
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPRAR-1
Summary: plugin properties are not used correctly
Type: Bug
Status: Unassigned
Priority: Critical
Original Estimate: 1 hour
Time Spent: Unknown
Remaining: 1 hour
Project: maven-rar-plugin
Fix Fors:
1.1
Versions:
1.0
Assignee:
Reporter: Felipe Leme
Created: Wed, 1 Sep 2004 1:43 PM
Updated: Wed, 1 Sep 2004 1:43 PM
Description:
The rar plugin defines many variables:
maven.rar.src=${maven.src.dir}/rar
maven.rar.descriptordir=${maven.rar.src}/META-INF
maven.rar.raxml=${maven.rar.descriptordir}/ra.xml
maven.rar.manifest=${maven.rar.descriptordir}/MANIFEST.MF
maven.rar.displayname=${pom.id}
maven.rar.resources=${maven.build.dir}/rar
But some of them are ignored. For instance, the descriptordir is not used and the only reference to the raxml is inside an echo tag:
<ant:echo>Building rar ${maven.final.name} with ra.xml "${maven.rar.raxml}"</ant:echo>
In other words, the way it is now, the ra.xml must be inside the directory defined by maven.rar.src, otherwise it won't be included, even if the raxml or descriptordir is defined (and that's really bad).
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPRAR-1) plugin properties are not used correctly
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPRAR-1?page=comments#action_41037 ]
Brett Porter commented on MPRAR-1:
----------------------------------
Axel, this patch doesn't look like it'll work to me unless maven.rar.descriptor.dir = META-INF which defeats the purpose.
> plugin properties are not used correctly
> ----------------------------------------
>
> Key: MPRAR-1
> URL: http://jira.codehaus.org/browse/MPRAR-1
> Project: maven-rar-plugin
> Type: Bug
> Versions: 1.0
> Reporter: Felipe Leme
> Priority: Critical
> Fix For: 1.1
> Attachments: plugin.jelly
>
> Original Estimate: 1 hour
> Remaining: 1 hour
>
> The rar plugin defines many variables:
> maven.rar.src=${maven.src.dir}/rar
> maven.rar.descriptordir=${maven.rar.src}/META-INF
> maven.rar.raxml=${maven.rar.descriptordir}/ra.xml
> maven.rar.manifest=${maven.rar.descriptordir}/MANIFEST.MF
> maven.rar.displayname=${pom.id}
> maven.rar.resources=${maven.build.dir}/rar
> But some of them are ignored. For instance, the descriptordir is not used and the only reference to the raxml is inside an echo tag:
> <ant:echo>Building rar ${maven.final.name} with ra.xml "${maven.rar.raxml}"</ant:echo>
> In other words, the way it is now, the ra.xml must be inside the directory defined by maven.rar.src, otherwise it won't be included, even if the raxml or descriptordir is defined (and that's really bad).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPRAR-1) plugin properties are not used correctly
Posted by "Axel Mueller (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPRAR-1?page=all ]
Axel Mueller updated MPRAR-1:
-----------------------------
Attachment: plugin.jelly
I have fixed the plugin to use maven.rar.descriptordir properly.
> plugin properties are not used correctly
> ----------------------------------------
>
> Key: MPRAR-1
> URL: http://jira.codehaus.org/browse/MPRAR-1
> Project: maven-rar-plugin
> Type: Bug
> Versions: 1.0
> Reporter: Felipe Leme
> Priority: Critical
> Fix For: 1.1
> Attachments: plugin.jelly
>
> Original Estimate: 1 hour
> Remaining: 1 hour
>
> The rar plugin defines many variables:
> maven.rar.src=${maven.src.dir}/rar
> maven.rar.descriptordir=${maven.rar.src}/META-INF
> maven.rar.raxml=${maven.rar.descriptordir}/ra.xml
> maven.rar.manifest=${maven.rar.descriptordir}/MANIFEST.MF
> maven.rar.displayname=${pom.id}
> maven.rar.resources=${maven.build.dir}/rar
> But some of them are ignored. For instance, the descriptordir is not used and the only reference to the raxml is inside an echo tag:
> <ant:echo>Building rar ${maven.final.name} with ra.xml "${maven.rar.raxml}"</ant:echo>
> In other words, the way it is now, the ra.xml must be inside the directory defined by maven.rar.src, otherwise it won't be included, even if the raxml or descriptordir is defined (and that's really bad).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Resolved: (MPRAR-1) plugin properties are not used correctly
Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPRAR-1?page=all ]
Stephane Nicoll resolved MPRAR-1:
---------------------------------
Resolution: Fixed
This is fixed, ra.xml file is now included wherever it is located.
> plugin properties are not used correctly
> ----------------------------------------
>
> Key: MPRAR-1
> URL: http://jira.codehaus.org/browse/MPRAR-1
> Project: maven-rar-plugin
> Type: Bug
> Versions: 1.0
> Reporter: Felipe Leme
> Assignee: Stephane Nicoll
> Priority: Critical
> Fix For: 1.1
> Attachments: plugin.jelly
>
> Original Estimate: 1 hour
> Remaining: 1 hour
>
> The rar plugin defines many variables:
> maven.rar.src=${maven.src.dir}/rar
> maven.rar.descriptordir=${maven.rar.src}/META-INF
> maven.rar.raxml=${maven.rar.descriptordir}/ra.xml
> maven.rar.manifest=${maven.rar.descriptordir}/MANIFEST.MF
> maven.rar.displayname=${pom.id}
> maven.rar.resources=${maven.build.dir}/rar
> But some of them are ignored. For instance, the descriptordir is not used and the only reference to the raxml is inside an echo tag:
> <ant:echo>Building rar ${maven.final.name} with ra.xml "${maven.rar.raxml}"</ant:echo>
> In other words, the way it is now, the ra.xml must be inside the directory defined by maven.rar.src, otherwise it won't be included, even if the raxml or descriptordir is defined (and that's really bad).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPRAR-1) plugin properties are not used
correctly
Posted by "Felipe Leme (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPRAR-1?page=comments#action_57253 ]
Felipe Leme commented on MPRAR-1:
---------------------------------
Stephane,
Could you please add a small test case for this issue (and also MPRAR-2)? I know the rar plugin does not have any testcase yet, but you could use other plugins (such as the maven-ear-plugin) as template...
-- Felipe
(PS: my maven environment is messed up right now, otherwise I would add such testcases myself...)
> plugin properties are not used correctly
> ----------------------------------------
>
> Key: MPRAR-1
> URL: http://jira.codehaus.org/browse/MPRAR-1
> Project: maven-rar-plugin
> Type: Bug
> Versions: 1.0
> Reporter: Felipe Leme
> Assignee: Stephane Nicoll
> Priority: Critical
> Fix For: 1.1
> Attachments: plugin.jelly
>
> Original Estimate: 1 hour
> Remaining: 1 hour
>
> The rar plugin defines many variables:
> maven.rar.src=${maven.src.dir}/rar
> maven.rar.descriptordir=${maven.rar.src}/META-INF
> maven.rar.raxml=${maven.rar.descriptordir}/ra.xml
> maven.rar.manifest=${maven.rar.descriptordir}/MANIFEST.MF
> maven.rar.displayname=${pom.id}
> maven.rar.resources=${maven.build.dir}/rar
> But some of them are ignored. For instance, the descriptordir is not used and the only reference to the raxml is inside an echo tag:
> <ant:echo>Building rar ${maven.final.name} with ra.xml "${maven.rar.raxml}"</ant:echo>
> In other words, the way it is now, the ra.xml must be inside the directory defined by maven.rar.src, otherwise it won't be included, even if the raxml or descriptordir is defined (and that's really bad).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org