[GitHub] [iceberg] massdosage commented on a change in pull request #1478: Enable Hive3 builds for iceberg-mr and iceberg-hive-metastore

[GitBox <gi...@apache.org>]

massdosage commented on a change in pull request #1478:
URL: https://github.com/apache/iceberg/pull/1478#discussion_r491911188



##########
File path: build.gradle
##########
@@ -458,14 +471,29 @@ project(':iceberg-mr') {
     testCompile("org.apache.calcite:calcite-core")
     testCompile("com.esotericsoftware:kryo-shaded:4.0.2")
     testCompile("com.fasterxml.jackson.core:jackson-annotations:2.6.5")
-    testCompile("com.klarna:hiverunner:5.2.1") {
+    testCompile("com.klarna:hiverunner") {
       exclude group: 'javax.jms', module: 'jms'
       exclude group: 'org.apache.hive', module: 'hive-exec'
       exclude group: 'org.codehaus.jettison', module: 'jettison'
       exclude group: 'org.apache.calcite.avatica'
     }
   }
 }
+if (!gradle.ext.hive3Enabled) {
+  project(':iceberg-mr-hive2') {
+    dependencies {
+      compile project(':iceberg-core')
+      compileOnly("org.apache.hive:hive-serde")
+    }
+  }
+} else {
+  project(':iceberg-mr-hive3') {
+    dependencies {
+      compile project(':iceberg-core')
+      compileOnly("org.apache.hive:hive-serde:3.1.2")

Review comment:
       Is this version not set in `versions-hive3.props` already? Or is there some reason you need to explicitly set it here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org