You are viewing a plain text version of this content. The canonical link for it is here.
Posted to infrastructure-issues@apache.org by "David Nalley (JIRA)" <ji...@apache.org> on 2014/07/28 22:43:40 UTC
[jira] [Closed] (INFRA-7153) mirrors.cgi doesn't ignore all HTML
comments
[ https://issues.apache.org/jira/browse/INFRA-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Nalley closed INFRA-7153.
-------------------------------
Resolution: Later
Kanak:
While this is indeed an issue, it's not something that is currently something that is a priority. Factoring into this decision is the fact that there is a clear workaround (removing the comments).
Thanks for reporting the issue
> mirrors.cgi doesn't ignore all HTML comments
> --------------------------------------------
>
> Key: INFRA-7153
> URL: https://issues.apache.org/jira/browse/INFRA-7153
> Project: Infrastructure
> Issue Type: Bug
> Components: Mirrors, Other/Misc
> Reporter: Kanak Biscuitwala
>
> We use the following setup for the Apache Helix website:
> 1. Source files are mirrored to http://helix.incubator.apache.org from https://svn.apache.org/repos/asf/incubator/helix/site-content
> 2. The source HTML files may include comments, specifically our download page https://svn.apache.org/repos/asf/incubator/helix/site-content/download.html contains the following due to the tool we use to generate the pages:
> <!-- Le HTML5 shim, for IE6-8 support of HTML5 elements -->
> <!--[if lt IE 9]>
> <script src="http://html5shim.googlecode.com/svn/trunk/html5.js"></script>
> <![endif]-->
> 3. Our .htaccess contains the following line:
> Redirect /download.html /download.cgi
> 4. Our download.cgi contains the following line:
> exec /www/www.apache.org/dyn/mirrors/mirrors.cgi $*
> 5. When visiting download.html (http://helix.incubator.apache.org/download.html), we get a Python traceback:
> Traceback (most recent call last):
> File "/www/www.apache.org/dyn/mirrors/mirrors.cgi", line 143, in mirrorwrap
> return mirrorsapp(environ, start_response)
> File "/www/www.apache.org/dyn/mirrors/mirrors.cgi", line 251, in mirrorsapp
> template.generate(output, data)
> File "/www/www.apache.org/dyn/mirrors/ezt.py", line 141, in generate
> self._execute(self.program, fp, ctx)
> File "/www/www.apache.org/dyn/mirrors/ezt.py", line 301, in _execute
> method(method_args, fp, ctx, filename, line_number)
> File "/www/www.apache.org/dyn/mirrors/ezt.py", line 321, in _cmd_subst
> fmt = _get_value(valref, ctx, filename, line_number)
> File "/www/www.apache.org/dyn/mirrors/ezt.py", line 486, in _get_value
> raise UnknownReference(refname, filename, line_number)
> UnknownReference: if in file /x1/www/helix.apache.org/download.html at line 30
> 6. Manually removing the commented lines I noted above fixes the issue.
> The mirror script should ignore all commented HTML when it's trying to generate the webpage, right?
--
This message was sent by Atlassian JIRA
(v6.2#6252)