You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by pvillard31 <gi...@git.apache.org> on 2016/11/10 23:44:31 UTC
[GitHub] nifi pull request #1206: NIFI-2912 Allow custom text in GenerateFlowFile
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/1206
NIFI-2912 Allow custom text in GenerateFlowFile
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-2912
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1206.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1206
----
commit 06df41be1e3f0961ccb5fe392a6127317d3da4f2
Author: Pierre Villard <pi...@gmail.com>
Date: 2016-11-10T23:44:06Z
NIFI-2912 Allow custom text in GenerateFlowFile
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1206: NIFI-2912 Allow custom text in GenerateFlowFile
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1206
I like those decisions. In the middle of something but will re-verify and then merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1206: NIFI-2912 Allow custom text in GenerateFlowFile
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1206
Hey @alopresto. I definitely agree with you. In fact what do you think about setting 0B as default File Size value and setting Text as default Data Format? This way user is only required to set one single property for custom text. There is no compatibility issue and I think it will be closer to what users are doing most of the time.
I just rebased/pushed with the additional changes, let me know if it is OK for you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1206: NIFI-2912 Allow custom text in GenerateFlowFile
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1206
@pvillard31 the only issue I encountered was that if a message is provided, the `File Size` field is still required, even though it is not used. In the custom validate method, can we either switch `File Size` required to `false` if `Custom Text` is populated, or provide a default value of `0B` for `File Size`?
Other than that, seems very useful, and I verified the `contrib-check`, tests, and build & install process.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1206: NIFI-2912 Allow custom text in GenerateFlowFile
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1206
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1206: NIFI-2912 Allow custom text in GenerateFlowFile
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1206
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---