You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2017/01/05 21:33:06 UTC
Review Request 55231: Authentication negotiation HTTP response should
be sent when Kerberos authentication is enabled
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55231/
-----------------------------------------------------------
Review request for Ambari, Attila Magyar, Jonathan Hurley, Laszlo Puskas, and Nate Cole.
Bugs: MBARI-19389
https://issues.apache.org/jira/browse/MBARI-19389
Repository: ambari
Description
-------
Authentication negotiation HTTP response should be automatically sent when needed when Kerberos authentication is enabled.
The expected HTTP response during authentication failure when Kerberos authentication into Ambari is enabled is as follows:
```
HTTP/1.1 401 Authentication requested
WWW-Authenticate: Negotiate
```
When Kerberos authentication into Ambari is not enabled the expected HTTP response for an authentication failure is:
```
HTTP/1.1 403 Missing authentication token
```
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/security/AmbariEntryPoint.java 7e0ff79
ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 9eca920
ambari-server/src/test/java/org/apache/ambari/server/security/AmbariEntryPointTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/55231/diff/
Testing
-------
Manually tested
Thanks,
Robert Levas
Re: Review Request 55231: Authentication negotiation HTTP response
should be sent when Kerberos authentication is enabled
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55231/#review160751
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Jan. 5, 2017, 4:33 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55231/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2017, 4:33 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Jonathan Hurley, Laszlo Puskas, and Nate Cole.
>
>
> Bugs: MBARI-19389
> https://issues.apache.org/jira/browse/MBARI-19389
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Authentication negotiation HTTP response should be automatically sent when needed when Kerberos authentication is enabled.
>
> The expected HTTP response during authentication failure when Kerberos authentication into Ambari is enabled is as follows:
> ```
> HTTP/1.1 401 Authentication requested
> WWW-Authenticate: Negotiate
> ```
>
> When Kerberos authentication into Ambari is not enabled the expected HTTP response for an authentication failure is:
> ```
> HTTP/1.1 403 Missing authentication token
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/security/AmbariEntryPoint.java 7e0ff79
> ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 9eca920
> ambari-server/src/test/java/org/apache/ambari/server/security/AmbariEntryPointTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55231/diff/
>
>
> Testing
> -------
>
> Manually tested
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 55231: Authentication negotiation HTTP response
should be sent when Kerberos authentication is enabled
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55231/#review160783
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 5, 2017, 9:33 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55231/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2017, 9:33 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Jonathan Hurley, Laszlo Puskas, and Nate Cole.
>
>
> Bugs: MBARI-19389
> https://issues.apache.org/jira/browse/MBARI-19389
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Authentication negotiation HTTP response should be automatically sent when needed when Kerberos authentication is enabled.
>
> The expected HTTP response during authentication failure when Kerberos authentication into Ambari is enabled is as follows:
> ```
> HTTP/1.1 401 Authentication requested
> WWW-Authenticate: Negotiate
> ```
>
> When Kerberos authentication into Ambari is not enabled the expected HTTP response for an authentication failure is:
> ```
> HTTP/1.1 403 Missing authentication token
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/security/AmbariEntryPoint.java 7e0ff79
> ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 9eca920
> ambari-server/src/test/java/org/apache/ambari/server/security/AmbariEntryPointTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55231/diff/
>
>
> Testing
> -------
>
> Manually tested
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 55231: Authentication negotiation HTTP response
should be sent when Kerberos authentication is enabled
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55231/#review160714
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 5, 2017, 4:33 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55231/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2017, 4:33 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Jonathan Hurley, Laszlo Puskas, and Nate Cole.
>
>
> Bugs: MBARI-19389
> https://issues.apache.org/jira/browse/MBARI-19389
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Authentication negotiation HTTP response should be automatically sent when needed when Kerberos authentication is enabled.
>
> The expected HTTP response during authentication failure when Kerberos authentication into Ambari is enabled is as follows:
> ```
> HTTP/1.1 401 Authentication requested
> WWW-Authenticate: Negotiate
> ```
>
> When Kerberos authentication into Ambari is not enabled the expected HTTP response for an authentication failure is:
> ```
> HTTP/1.1 403 Missing authentication token
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/security/AmbariEntryPoint.java 7e0ff79
> ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 9eca920
> ambari-server/src/test/java/org/apache/ambari/server/security/AmbariEntryPointTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55231/diff/
>
>
> Testing
> -------
>
> Manually tested
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 55231: Authentication negotiation HTTP response
should be sent when Kerberos authentication is enabled
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55231/
-----------------------------------------------------------
(Updated Jan. 6, 2017, 8:29 p.m.)
Review request for Ambari, Attila Magyar, Jonathan Hurley, Laszlo Puskas, and Nate Cole.
Bugs: AMBARI-19389
https://issues.apache.org/jira/browse/AMBARI-19389
Repository: ambari
Description
-------
Authentication negotiation HTTP response should be automatically sent when needed when Kerberos authentication is enabled.
The expected HTTP response during authentication failure when Kerberos authentication into Ambari is enabled is as follows:
```
HTTP/1.1 401 Authentication requested
WWW-Authenticate: Negotiate
```
When Kerberos authentication into Ambari is not enabled the expected HTTP response for an authentication failure is:
```
HTTP/1.1 403 Missing authentication token
```
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/security/AmbariEntryPoint.java 7e0ff79
ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 9eca920
ambari-server/src/test/java/org/apache/ambari/server/security/AmbariEntryPointTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/55231/diff/
Testing
-------
Manually tested
Thanks,
Robert Levas