You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/06/05 16:21:40 UTC
[GitHub] [orc] noirello opened a new pull request #713: ORC-377: [c++] Add SnappyCompressionStream
noirello opened a new pull request #713:
URL: https://github.com/apache/orc/pull/713
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
A new BlockCompressionStream class was implemented for Snappy compression.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
The C++ Writer doesn't support Snappy compression. This PR aims to fix that.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
The existing compression tests were copied and changed to use Snappy compression.
PR #282 aims for the very same thing, but it's not complete and inactive for a while now. The BlockCompressionStream has been introduced since it was opened, thus it was easier for me to start over from the current state and open a new pull request.
I hope it's not a problem that I've stepped in to add the functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on a change in pull request #713: ORC-377: [c++] Add SnappyCompressionStream
Posted by GitBox <gi...@apache.org>.
wgtmac commented on a change in pull request #713:
URL: https://github.com/apache/orc/pull/713#discussion_r648423627
##########
File path: c++/src/Compression.cc
##########
@@ -1030,6 +1030,47 @@ DIAGNOSTIC_POP
state = nullptr;
}
+ /**
+ * Snappy block compression
+ */
+ class SnappyCompressionStream: public BlockCompressionStream {
+ public:
+ SnappyCompressionStream(OutputStream * outStream,
+ int compressionLevel,
+ uint64_t capacity,
+ uint64_t blockSize,
+ MemoryPool& pool)
+ : BlockCompressionStream(outStream,
+ compressionLevel,
+ capacity,
+ blockSize,
+ pool) {
+ }
+
+ virtual std::string getName() const override {
+ return "SnappyCompressionStream";
+ }
+
+ virtual ~SnappyCompressionStream() override {
+ }
Review comment:
// PASS
##########
File path: c++/src/Compression.cc
##########
@@ -1030,6 +1030,47 @@ DIAGNOSTIC_POP
state = nullptr;
}
+ /**
+ * Snappy block compression
+ */
+ class SnappyCompressionStream: public BlockCompressionStream {
+ public:
+ SnappyCompressionStream(OutputStream * outStream,
+ int compressionLevel,
+ uint64_t capacity,
+ uint64_t blockSize,
+ MemoryPool& pool)
+ : BlockCompressionStream(outStream,
+ compressionLevel,
+ capacity,
+ blockSize,
+ pool) {
+ }
+
+ virtual std::string getName() const override {
+ return "SnappyCompressionStream";
+ }
+
+ virtual ~SnappyCompressionStream() override {
+ }
+
+ protected:
+ virtual uint64_t doBlockCompression() override;
+
+ virtual uint64_t estimateMaxCompressionSize() override {
+ return static_cast<uint64_t>(snappy::MaxCompressedLength(static_cast<size_t>(bufferSize)));
Review comment:
break this long line into two
##########
File path: c++/src/Compression.cc
##########
@@ -1204,7 +1245,12 @@ DIAGNOSTIC_PUSH
(new Lz4CompressionSteam(
outStream, level, bufferCapacity, compressionBlockSize, pool));
}
- case CompressionKind_SNAPPY:
+ case CompressionKind_SNAPPY: {
+ int level = 0;
Review comment:
Does snappy support different levels? If true, we should assign different levels according to CompressionStrategy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #713: ORC-377: [c++] Add SnappyCompressionStream
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #713:
URL: https://github.com/apache/orc/pull/713#issuecomment-869065072
Thank you. I updated the JIRA for Apache ORC 1.7.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] noirello commented on a change in pull request #713: ORC-377: [c++] Add SnappyCompressionStream
Posted by GitBox <gi...@apache.org>.
noirello commented on a change in pull request #713:
URL: https://github.com/apache/orc/pull/713#discussion_r648639755
##########
File path: c++/src/Compression.cc
##########
@@ -1204,7 +1245,12 @@ DIAGNOSTIC_PUSH
(new Lz4CompressionSteam(
outStream, level, bufferCapacity, compressionBlockSize, pool));
}
- case CompressionKind_SNAPPY:
+ case CompressionKind_SNAPPY: {
+ int level = 0;
Review comment:
There's no mention about it in the header file, and I couldn't find anything elsewhere, that would indicate it does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac merged pull request #713: ORC-377: [c++] Add SnappyCompressionStream
Posted by GitBox <gi...@apache.org>.
wgtmac merged pull request #713:
URL: https://github.com/apache/orc/pull/713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org