[jira] [Commented] (PROTON-159) port proton to C++

["Cliff Jansen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561520#comment-13561520 ] 

Cliff Jansen commented on PROTON-159:
-------------------------------------

I have broken up the original patch into 4 more digestible (more tasty?) morsels.

  https://reviews.apache.org/r/8223   (-Wc++-compat)
  https://reviews.apache.org/r/9085   (-Wwrite-strings)
  https://reviews.apache.org/r/9086   (-Wsign-compare)
  https://reviews.apache.org/r/9088   (-Wvla)

In combination they allow as much C++ checking that a regular build using gcc can do (although there may be more such args I haven't found).

Further work to get it all running on Windows Visual Studio (in C++) indicates a likely 3 additional patches, roughly:

  - additional stuff for a g++ build (mainly compound literals, const & enum fussiness)
  - symbol exports
  - differences between VS C++ and g++

The last one mainly has to do with replacing C99 types and definitions that are absent in (at least some) Visual Studio versions.  things like int64_t, ssize_t, PRIx format specifiers, atoll()...
                
> port proton to C++
> ------------------
>
>                 Key: PROTON-159
>                 URL: https://issues.apache.org/jira/browse/PROTON-159
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-c
>    Affects Versions: 0.3
>            Reporter: Cliff Jansen
>         Attachments: proton-159-0.diff, proton-159-0-partial.diff
>
>
> Make code compile in both C99 and C++, using the gnu toolchain.  This is a necessary first step
> towards a Microsoft Visual Studio port (where the compiler supports C++ but not C99).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira