You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by "furqaankhan (via GitHub)" <gi...@apache.org> on 2023/07/28 02:47:33 UTC
[GitHub] [sedona] furqaankhan opened a new pull request, #930: [DOCS] Add example outputs to all Sedona functions - 10
furqaankhan opened a new pull request, #930:
URL: https://github.com/apache/sedona/pull/930
## Did you read the Contributor Guide?
- No, I haven't read it.
## Is this PR related to a JIRA ticket?
- No, this is a documentation update. The PR name follows the format `[DOCS] my subject`.
## What changes were proposed in this PR?
Edited the few remaining functions.
## How was this patch tested?
On my local Ubuntu VM
## Did this PR include necessary documentation updates?
- Yes, I have updated the documentation update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sedona] jiayuasu commented on a diff in pull request #930: [DOCS] Add example outputs to all Sedona functions - 10
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on code in PR #930:
URL: https://github.com/apache/sedona/pull/930#discussion_r1277081362
##########
docs/api/flink/Function.md:
##########
@@ -927,35 +925,16 @@ Since: `1.4.1`
Example:
-```sql
-SELECT ST_Force3D(df.geometry) AS geom
-from df
-```
-
-Input: `LINESTRING(0 1, 1 2, 2 1)`
-
-Output: `LINESTRING Z(0 1 0, 1 2 0, 2 1 0)`
-
-Input: `POLYGON((0 0 2,0 5 2,5 0 2,0 0 2),(1 1 2,3 1 2,1 3 2,1 1 2))`
-
-Output: `POLYGON Z((0 0 2,0 5 2,5 0 2,0 0 2),(1 1 2,3 1 2,1 3 2,1 1 2))`
```sql
Review Comment:
Please add the `LINESTRING EMPTY` example
##########
docs/api/flink/Function.md:
##########
@@ -169,40 +169,38 @@ Since: `1.5.0`
Example:
```sql
-ST_Angle(p1, p2, p3, p4)
+ST_Angle(ST_GeomFromWKT('POINT(0 0)'), ST_GeomFromWKT('POINT (1 1)'), ST_GeomFromWKT('POINT(1 0)'), ST_GeomFromWKT('POINT(6 2)'))
```
-Input: `p1: POINT (0 0)`
-
-Input: `p2: POINT (1 1)`
-
-Input: `p3: POINT (1 0)`
+Output:
-Input: `p4: POINT(6 2)`
+```
+0.4048917862850834
+```
-Output: 0.4048917862850834
+Example:
```sql
-ST_Angle(p1, p2, p3)
+ST_Angle(ST_GeomFromWKT('POINT (1 1)'), ST_GeomFromWKT('POINT (0 0)'), ST_GeomFromWKT('POINT(3 2)'))
Review Comment:
Add `SELECT` please
##########
docs/api/flink/Function.md:
##########
@@ -1943,13 +1944,15 @@ Since: `1.4.1`
Example:
-Input: `ST_Translate(GEOMETRYCOLLECTION(MULTIPOLYGON (((1 0, 1 1, 2 1, 2 0, 1 0)), ((1 2, 3 4, 3 5, 1 2))), POINT(1, 1, 1), LINESTRING EMPTY), 2, 2, 3)`
-
-Output: `GEOMETRYCOLLECTION(MULTIPOLYGON (((3 2, 3 3, 4 3, 4 2, 3 2)), ((3 4, 5 6, 5 7, 3 4))), POINT(3, 3, 4), LINESTRING EMPTY)`
+```sql
Review Comment:
Please add examples of other types of inputs. Don't just directly remove them.
##########
docs/api/flink/Function.md:
##########
@@ -927,35 +925,16 @@ Since: `1.4.1`
Example:
-```sql
-SELECT ST_Force3D(df.geometry) AS geom
-from df
-```
-
-Input: `LINESTRING(0 1, 1 2, 2 1)`
-
-Output: `LINESTRING Z(0 1 0, 1 2 0, 2 1 0)`
-
-Input: `POLYGON((0 0 2,0 5 2,5 0 2,0 0 2),(1 1 2,3 1 2,1 3 2,1 1 2))`
-
-Output: `POLYGON Z((0 0 2,0 5 2,5 0 2,0 0 2),(1 1 2,3 1 2,1 3 2,1 1 2))`
```sql
-SELECT ST_Force3D(df.geometry, 2.3) AS geom
-from df
+SELECT ST_AsText(ST_Force3D(ST_GeomFromText('POLYGON((0 0 2,0 5 2,5 0 2,0 0 2),(1 1 2,3 1 2,1 3 2,1 1 2))')))
```
Review Comment:
Please add the Zvalue input example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sedona] jiayuasu commented on pull request #930: [DOCS] Add example outputs to all Sedona functions - 10
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on PR #930:
URL: https://github.com/apache/sedona/pull/930#issuecomment-1656098548
@furqaankhan Please fix the git conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sedona] jiayuasu merged pull request #930: [DOCS] Add example outputs to all Sedona functions - 10
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #930:
URL: https://github.com/apache/sedona/pull/930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org