You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/09/10 18:34:14 UTC

[GitHub] [guacamole-server] mike-jumper commented on a change in pull request #301: GUACAMOLE-1174: Added exec call implementation for kubernetes protocol

mike-jumper commented on a change in pull request #301:
URL: https://github.com/apache/guacamole-server/pull/301#discussion_r486554779



##########
File path: src/protocols/kubernetes/settings.c
##########
@@ -31,6 +31,8 @@ const char* GUAC_KUBERNETES_CLIENT_ARGS[] = {
     "namespace",
     "pod",
     "container",
+    "use-exec",
+    "exec-command",

Review comment:
       Why not just `exec-command`, defaulting to "attach" if no command is provided for execution?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org