You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Jason Rutherglen (JIRA)" <ji...@apache.org> on 2011/07/09 04:34:16 UTC
[jira] [Created] (LUCENE-3296) Enable passing a config into
PKIndexSplitter
Enable passing a config into PKIndexSplitter
--------------------------------------------
Key: LUCENE-3296
URL: https://issues.apache.org/jira/browse/LUCENE-3296
Project: Lucene - Java
Issue Type: Improvement
Components: core/other
Affects Versions: 4.0
Reporter: Jason Rutherglen
Priority: Trivial
I need to be able to pass the IndexWriterConfig into the IW used by PKIndexSplitter.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3296) Enable passing a config into
PKIndexSplitter
Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer updated LUCENE-3296:
------------------------------------
Attachment: LUCENE-3296.patch
this patch includes added version to MultipassIndexSplitter ctor.
I am going to commit this and backport to 3.x
> Enable passing a config into PKIndexSplitter
> --------------------------------------------
>
> Key: LUCENE-3296
> URL: https://issues.apache.org/jira/browse/LUCENE-3296
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/other
> Affects Versions: 3.3, 4.0
> Reporter: Jason Rutherglen
> Assignee: Simon Willnauer
> Priority: Trivial
> Attachments: LUCENE-3296.patch, LUCENE-3296.patch, LUCENE-3296.patch, LUCENE-3296.patch
>
>
> I need to be able to pass the IndexWriterConfig into the IW used by PKIndexSplitter.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3296) Enable passing a config into
PKIndexSplitter
Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer resolved LUCENE-3296.
-------------------------------------
Resolution: Fixed
Fix Version/s: 4.0
3.4
Lucene Fields: [New, Patch Available] (was: [New])
Committed to trunk and backported to 3.x. I marked parts in 3.x as deprecated.
> Enable passing a config into PKIndexSplitter
> --------------------------------------------
>
> Key: LUCENE-3296
> URL: https://issues.apache.org/jira/browse/LUCENE-3296
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/other
> Affects Versions: 3.3, 4.0
> Reporter: Jason Rutherglen
> Assignee: Simon Willnauer
> Priority: Trivial
> Fix For: 3.4, 4.0
>
> Attachments: LUCENE-3296.patch, LUCENE-3296.patch, LUCENE-3296.patch, LUCENE-3296.patch
>
>
> I need to be able to pass the IndexWriterConfig into the IW used by PKIndexSplitter.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3296) Enable passing a config into
PKIndexSplitter
Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer updated LUCENE-3296:
------------------------------------
Attachment: LUCENE-3296.patch
here is a new patch. I added a second IWC since we can not reuse IWC instances across IW due to SetOnce restrictions. I also moved out the VERSION_CURRENT and made it a ctor argument. We should not randomly use the VERSION_CURRENT but rather be consistent when we use version.
> Enable passing a config into PKIndexSplitter
> --------------------------------------------
>
> Key: LUCENE-3296
> URL: https://issues.apache.org/jira/browse/LUCENE-3296
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/other
> Affects Versions: 3.3, 4.0
> Reporter: Jason Rutherglen
> Assignee: Simon Willnauer
> Priority: Trivial
> Attachments: LUCENE-3296.patch, LUCENE-3296.patch, LUCENE-3296.patch
>
>
> I need to be able to pass the IndexWriterConfig into the IW used by PKIndexSplitter.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3296) Enable passing a config into
PKIndexSplitter
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062349#comment-13062349 ]
Jason Rutherglen commented on LUCENE-3296:
------------------------------------------
That was in there previously. Lets change it.
> Enable passing a config into PKIndexSplitter
> --------------------------------------------
>
> Key: LUCENE-3296
> URL: https://issues.apache.org/jira/browse/LUCENE-3296
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/other
> Affects Versions: 4.0
> Reporter: Jason Rutherglen
> Assignee: Simon Willnauer
> Priority: Trivial
> Attachments: LUCENE-3296.patch
>
>
> I need to be able to pass the IndexWriterConfig into the IW used by PKIndexSplitter.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3296) Enable passing a config into
PKIndexSplitter
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062862#comment-13062862 ]
Jason Rutherglen commented on LUCENE-3296:
------------------------------------------
Uwe, the first patch [1] is implemented with CURRENT.
1. https://issues.apache.org/jira/secure/attachment/12485805/LUCENE-3296.patch
> Enable passing a config into PKIndexSplitter
> --------------------------------------------
>
> Key: LUCENE-3296
> URL: https://issues.apache.org/jira/browse/LUCENE-3296
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/other
> Affects Versions: 3.3, 4.0
> Reporter: Jason Rutherglen
> Assignee: Simon Willnauer
> Priority: Trivial
> Attachments: LUCENE-3296.patch, LUCENE-3296.patch
>
>
> I need to be able to pass the IndexWriterConfig into the IW used by PKIndexSplitter.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3296) Enable passing a config into
PKIndexSplitter
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Rutherglen updated LUCENE-3296:
-------------------------------------
Attachment: LUCENE-3296.patch
Patch, all tests pass.
> Enable passing a config into PKIndexSplitter
> --------------------------------------------
>
> Key: LUCENE-3296
> URL: https://issues.apache.org/jira/browse/LUCENE-3296
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/other
> Affects Versions: 4.0
> Reporter: Jason Rutherglen
> Priority: Trivial
> Attachments: LUCENE-3296.patch
>
>
> I need to be able to pass the IndexWriterConfig into the IW used by PKIndexSplitter.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3296) Enable passing a config into
PKIndexSplitter
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-3296:
----------------------------------
Affects Version/s: 3.3
> Enable passing a config into PKIndexSplitter
> --------------------------------------------
>
> Key: LUCENE-3296
> URL: https://issues.apache.org/jira/browse/LUCENE-3296
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/other
> Affects Versions: 3.3, 4.0
> Reporter: Jason Rutherglen
> Assignee: Simon Willnauer
> Priority: Trivial
> Attachments: LUCENE-3296.patch, LUCENE-3296.patch
>
>
> I need to be able to pass the IndexWriterConfig into the IW used by PKIndexSplitter.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Issue Comment Edited] (LUCENE-3296) Enable passing a config
into PKIndexSplitter
Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063249#comment-13063249 ]
Simon Willnauer edited comment on LUCENE-3296 at 7/11/11 9:54 AM:
------------------------------------------------------------------
here is a new patch. I added a second IWC since we can not reuse IWC instances across IW due to SetOnce restrictions. I also moved out the VERSION_CURRENT and made it a ctor argument. We should not randomly use the VERSION_CURRENT but rather be consistent when we use version.
bq. Simon: The Version.LUCENE_CURRENT is not important here, for easier porting, the version should be LUCENE_CURRENT (and it was before Jason's patch). Else we will have to always upgrade it with every new release. The same applies to the IndexUpdater class in core, it also uses LUCENE_CURRENT when you not pass in anything (as the version is completely useless for simple merge operations - like here).
not entirely true, we use the index splitter in 3.x and if you upgrade from 3.1 to 3.2 you get a new mergepolicy by default which doesn't merge in order. I think its a problem that this version is not in 3.x yet so let fix it properly and backport.
Simon
was (Author: simonw):
here is a new patch. I added a second IWC since we can not reuse IWC instances across IW due to SetOnce restrictions. I also moved out the VERSION_CURRENT and made it a ctor argument. We should not randomly use the VERSION_CURRENT but rather be consistent when we use version.
> Enable passing a config into PKIndexSplitter
> --------------------------------------------
>
> Key: LUCENE-3296
> URL: https://issues.apache.org/jira/browse/LUCENE-3296
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/other
> Affects Versions: 3.3, 4.0
> Reporter: Jason Rutherglen
> Assignee: Simon Willnauer
> Priority: Trivial
> Attachments: LUCENE-3296.patch, LUCENE-3296.patch, LUCENE-3296.patch
>
>
> I need to be able to pass the IndexWriterConfig into the IW used by PKIndexSplitter.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3296) Enable passing a config into
PKIndexSplitter
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063261#comment-13063261 ]
Uwe Schindler commented on LUCENE-3296:
---------------------------------------
bq. We should not randomly use the VERSION_CURRENT but rather be consistent when we use version.
I agree, but when you backport to 3.4, you have to keep backwards compatibility, so only deprecate the ctor there.
IndexUpgrader only uses LUCENE_CURRENT when you invoke from command line, in all other cases its required arg, so we are consistent here.
We should also look at the other IndexSplitters in this package!
> Enable passing a config into PKIndexSplitter
> --------------------------------------------
>
> Key: LUCENE-3296
> URL: https://issues.apache.org/jira/browse/LUCENE-3296
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/other
> Affects Versions: 3.3, 4.0
> Reporter: Jason Rutherglen
> Assignee: Simon Willnauer
> Priority: Trivial
> Attachments: LUCENE-3296.patch, LUCENE-3296.patch, LUCENE-3296.patch
>
>
> I need to be able to pass the IndexWriterConfig into the IW used by PKIndexSplitter.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3296) Enable passing a config into
PKIndexSplitter
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062822#comment-13062822 ]
Uwe Schindler commented on LUCENE-3296:
---------------------------------------
Simon: The Version.LUCENE_CURRENT is not important here, for easier porting, the version should be LUCENE_CURRENT (and it was before Jason's patch). Else we will have to always upgrade it with every new release. The same applies to the IndexUpdater class in core, it also uses LUCENE_CURRENT when you not pass in anything (as the version is completely useless for simple merge operations - like here).
I would take this issue, but with LUCENE_CURRENT.
> Enable passing a config into PKIndexSplitter
> --------------------------------------------
>
> Key: LUCENE-3296
> URL: https://issues.apache.org/jira/browse/LUCENE-3296
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/other
> Affects Versions: 4.0
> Reporter: Jason Rutherglen
> Assignee: Simon Willnauer
> Priority: Trivial
> Attachments: LUCENE-3296.patch, LUCENE-3296.patch
>
>
> I need to be able to pass the IndexWriterConfig into the IW used by PKIndexSplitter.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3296) Enable passing a config into
PKIndexSplitter
Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062334#comment-13062334 ]
Simon Willnauer commented on LUCENE-3296:
-----------------------------------------
looks good.. do you have to use Version.LUCENE_CURRENT in the ctors or can you pass in a version. using Version.LUCENE_CURRENT is discouraged for several reasons.
> Enable passing a config into PKIndexSplitter
> --------------------------------------------
>
> Key: LUCENE-3296
> URL: https://issues.apache.org/jira/browse/LUCENE-3296
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/other
> Affects Versions: 4.0
> Reporter: Jason Rutherglen
> Priority: Trivial
> Attachments: LUCENE-3296.patch
>
>
> I need to be able to pass the IndexWriterConfig into the IW used by PKIndexSplitter.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Assigned] (LUCENE-3296) Enable passing a config into
PKIndexSplitter
Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer reassigned LUCENE-3296:
---------------------------------------
Assignee: Simon Willnauer
> Enable passing a config into PKIndexSplitter
> --------------------------------------------
>
> Key: LUCENE-3296
> URL: https://issues.apache.org/jira/browse/LUCENE-3296
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/other
> Affects Versions: 4.0
> Reporter: Jason Rutherglen
> Assignee: Simon Willnauer
> Priority: Trivial
> Attachments: LUCENE-3296.patch
>
>
> I need to be able to pass the IndexWriterConfig into the IW used by PKIndexSplitter.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3296) Enable passing a config into
PKIndexSplitter
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063259#comment-13063259 ]
Uwe Schindler commented on LUCENE-3296:
---------------------------------------
bq. not entirely true, we use the index splitter in 3.x and if you upgrade from 3.1 to 3.2 you get a new mergepolicy by default which doesn't merge in order. I think its a problem that this version is not in 3.x yet so let fix it properly and backport.
PKIndexSplitter is new in 3.3, so you would never used it with older versions...
> Enable passing a config into PKIndexSplitter
> --------------------------------------------
>
> Key: LUCENE-3296
> URL: https://issues.apache.org/jira/browse/LUCENE-3296
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/other
> Affects Versions: 3.3, 4.0
> Reporter: Jason Rutherglen
> Assignee: Simon Willnauer
> Priority: Trivial
> Attachments: LUCENE-3296.patch, LUCENE-3296.patch, LUCENE-3296.patch
>
>
> I need to be able to pass the IndexWriterConfig into the IW used by PKIndexSplitter.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3296) Enable passing a config into
PKIndexSplitter
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062823#comment-13062823 ]
Uwe Schindler commented on LUCENE-3296:
---------------------------------------
btw.: The LUCENE_CURRENT was inserted by myself in the orginal code :-)
> Enable passing a config into PKIndexSplitter
> --------------------------------------------
>
> Key: LUCENE-3296
> URL: https://issues.apache.org/jira/browse/LUCENE-3296
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/other
> Affects Versions: 4.0
> Reporter: Jason Rutherglen
> Assignee: Simon Willnauer
> Priority: Trivial
> Attachments: LUCENE-3296.patch, LUCENE-3296.patch
>
>
> I need to be able to pass the IndexWriterConfig into the IW used by PKIndexSplitter.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3296) Enable passing a config into
PKIndexSplitter
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Rutherglen updated LUCENE-3296:
-------------------------------------
Attachment: LUCENE-3296.patch
This patch uses LUCENE_40. All tests pass.
> Enable passing a config into PKIndexSplitter
> --------------------------------------------
>
> Key: LUCENE-3296
> URL: https://issues.apache.org/jira/browse/LUCENE-3296
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/other
> Affects Versions: 4.0
> Reporter: Jason Rutherglen
> Assignee: Simon Willnauer
> Priority: Trivial
> Attachments: LUCENE-3296.patch, LUCENE-3296.patch
>
>
> I need to be able to pass the IndexWriterConfig into the IW used by PKIndexSplitter.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org