You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2026/06/13 14:18:01 UTC
[PR] docs: adopt issue #4419 terminology in Understanding Comet Plans guide [datafusion-comet]
andygrove opened a new pull request, #4650:
URL: https://github.com/apache/datafusion-comet/pull/4650
## Which issue does this PR close?
Part of #4419.
## Rationale for this change
Issue #4419 points out that the word "native" is overloaded across Comet's docs, carrying three different meanings (Rust implementation, Comet pipeline membership, and scan type). The issue proposes a terminology framework that keeps a few unambiguous compound forms (such as "native Rust", "native shuffle", and operator names like `CometNativeScan`) but otherwise replaces bare "native" with precise terms.
The "Understanding Comet Plans" page is the central user-facing doc that explains these concepts, so it is the highest-impact place to start. This PR keeps the change focused on that one page rather than attempting to clean up every doc at once.
## What changes are included in this PR?
In `docs/source/user-guide/latest/understanding-comet-plans.md`:
- Replace bare "native" with the implementation-language term where it means Rust ("Rust-implemented", "implemented in Rust", "runs in Rust via DataFusion").
- Use "Comet pipeline" / "runs in Comet" / "falls back to Spark" for pipeline-membership and fallback wording.
- Rename the "Native Execution Operators" section to "Native Rust Operators" to pair symmetrically with "JVM-Side Operators".
- Keep the compound forms the issue allows: "native Rust", "native shuffle" (paired with the JVM columnar shuffle), and operator/config names.
## How are these changes tested?
Documentation-only change. Verified with `prettier --check`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] docs: adopt issue #4419 terminology in Understanding Comet Plans guide [datafusion-comet]
Posted by "mbutrovich (via GitHub)" <gi...@apache.org>.
mbutrovich merged PR #4650:
URL: https://github.com/apache/datafusion-comet/pull/4650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] docs: adopt issue #4419 terminology in Understanding Comet Plans guide [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #4650:
URL: https://github.com/apache/datafusion-comet/pull/4650#discussion_r3408700560
##########
docs/source/user-guide/latest/understanding-comet-plans.md:
##########
@@ -62,9 +63,9 @@ the same plan is shown in the Spark SQL UI. When reading a plan, look for:
## Fallback
-A "fallback" happens when Comet cannot translate part of a plan into native
-execution. Fallback can be partial (a subtree falls back while the rest stays
-native) or full (no Comet nodes appear).
+A "fallback" happens when Comet cannot run part of a plan in the Comet
Review Comment:
should we also mention fallback to columnar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org